Commit fb5a613b authored by Andreea-Cristina Bernat's avatar Andreea-Cristina Bernat Committed by Steven Rostedt

kernel: trace_syscalls: Replace rcu_assign_pointer() with RCU_INIT_POINTER()

The uses of "rcu_assign_pointer()" are NULLing out the pointers.
According to RCU_INIT_POINTER()'s block comment:
"1.   This use of RCU_INIT_POINTER() is NULLing out the pointer"
it is better to use it instead of rcu_assign_pointer() because it has a
smaller overhead.

The following Coccinelle semantic patch was used:
@@
@@

- rcu_assign_pointer
+ RCU_INIT_POINTER
  (..., NULL)

Link: http://lkml.kernel.org/p/20140822142822.GA32391@adaSigned-off-by: default avatarAndreea-Cristina Bernat <bernat.ada@gmail.com>
Signed-off-by: default avatarSteven Rostedt <rostedt@goodmis.org>
parent 3a630178
...@@ -425,7 +425,7 @@ static void unreg_event_syscall_enter(struct ftrace_event_file *file, ...@@ -425,7 +425,7 @@ static void unreg_event_syscall_enter(struct ftrace_event_file *file,
return; return;
mutex_lock(&syscall_trace_lock); mutex_lock(&syscall_trace_lock);
tr->sys_refcount_enter--; tr->sys_refcount_enter--;
rcu_assign_pointer(tr->enter_syscall_files[num], NULL); RCU_INIT_POINTER(tr->enter_syscall_files[num], NULL);
if (!tr->sys_refcount_enter) if (!tr->sys_refcount_enter)
unregister_trace_sys_enter(ftrace_syscall_enter, tr); unregister_trace_sys_enter(ftrace_syscall_enter, tr);
mutex_unlock(&syscall_trace_lock); mutex_unlock(&syscall_trace_lock);
...@@ -463,7 +463,7 @@ static void unreg_event_syscall_exit(struct ftrace_event_file *file, ...@@ -463,7 +463,7 @@ static void unreg_event_syscall_exit(struct ftrace_event_file *file,
return; return;
mutex_lock(&syscall_trace_lock); mutex_lock(&syscall_trace_lock);
tr->sys_refcount_exit--; tr->sys_refcount_exit--;
rcu_assign_pointer(tr->exit_syscall_files[num], NULL); RCU_INIT_POINTER(tr->exit_syscall_files[num], NULL);
if (!tr->sys_refcount_exit) if (!tr->sys_refcount_exit)
unregister_trace_sys_exit(ftrace_syscall_exit, tr); unregister_trace_sys_exit(ftrace_syscall_exit, tr);
mutex_unlock(&syscall_trace_lock); mutex_unlock(&syscall_trace_lock);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment