Commit fb8d14e1 authored by Wu Fengguang's avatar Wu Fengguang Committed by Linus Torvalds

[PATCH] mm: shrink_inactive_lis() nr_scan accounting fix

In shrink_inactive_list(), nr_scan is not accounted when nr_taken is 0.
But 0 pages taken does not mean 0 pages scanned.

Move the goto statement below the accounting code to fix it.
Signed-off-by: default avatarWu Fengguang <wfg@mail.ustc.edu.cn>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent c9b02d97
...@@ -1132,9 +1132,6 @@ static unsigned long shrink_inactive_list(unsigned long max_scan, ...@@ -1132,9 +1132,6 @@ static unsigned long shrink_inactive_list(unsigned long max_scan,
zone->pages_scanned += nr_scan; zone->pages_scanned += nr_scan;
spin_unlock_irq(&zone->lru_lock); spin_unlock_irq(&zone->lru_lock);
if (nr_taken == 0)
goto done;
nr_scanned += nr_scan; nr_scanned += nr_scan;
nr_freed = shrink_page_list(&page_list, sc); nr_freed = shrink_page_list(&page_list, sc);
nr_reclaimed += nr_freed; nr_reclaimed += nr_freed;
...@@ -1146,6 +1143,9 @@ static unsigned long shrink_inactive_list(unsigned long max_scan, ...@@ -1146,6 +1143,9 @@ static unsigned long shrink_inactive_list(unsigned long max_scan,
__mod_page_state_zone(zone, pgscan_direct, nr_scan); __mod_page_state_zone(zone, pgscan_direct, nr_scan);
__mod_page_state_zone(zone, pgsteal, nr_freed); __mod_page_state_zone(zone, pgsteal, nr_freed);
if (nr_taken == 0)
goto done;
spin_lock(&zone->lru_lock); spin_lock(&zone->lru_lock);
/* /*
* Put back any unfreeable pages. * Put back any unfreeable pages.
...@@ -1166,8 +1166,9 @@ static unsigned long shrink_inactive_list(unsigned long max_scan, ...@@ -1166,8 +1166,9 @@ static unsigned long shrink_inactive_list(unsigned long max_scan,
} }
} }
} while (nr_scanned < max_scan); } while (nr_scanned < max_scan);
spin_unlock_irq(&zone->lru_lock); spin_unlock(&zone->lru_lock);
done: done:
local_irq_enable();
pagevec_release(&pvec); pagevec_release(&pvec);
return nr_reclaimed; return nr_reclaimed;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment