- 19 May, 2015 40 commits
-
-
Ingo Molnar authored
Standardize the various boot time messages printed during FPU detection: - Use a common 'x86/fpu: ' prefix for consistency and to make it easy to grep boot logs for FPU related messages - Correct speling errors - Add printout for the legacy FPU case as well - Clarify messages Reviewed-by:
Borislav Petkov <bp@alien8.de> Cc: Andy Lutomirski <luto@amacapital.net> Cc: Dave Hansen <dave.hansen@linux.intel.com> Cc: Fenghua Yu <fenghua.yu@intel.com> Cc: H. Peter Anvin <hpa@zytor.com> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Oleg Nesterov <oleg@redhat.com> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Thomas Gleixner <tglx@linutronix.de> Signed-off-by:
Ingo Molnar <mingo@kernel.org>
-
Ingo Molnar authored
asm/fpu/api.h does not contain any defines useful to assembly code, and no assembly code includes asm/fpu/api.h. Remove the historic #ifndef __ASSEMBLY__ leftover guard. Reviewed-by:
-
Ingo Molnar authored
So this code surprised me - and being surprised when reading FPU code does not help maintainability of an already overly complex subsystem. Remove the obfuscation and just don't use __init annotation for now. Anyone who wants to free these ~600 bytes of xstate_enable_boot_cpu() should implement it cleanly. Reviewed-by:
-
Ingo Molnar authored
fpu/types.h gets included everywhere, move the MXCSR_DEFAULT to fpu/internal.h, the place where it's used. Reviewed-by:
-
Ingo Molnar authored
This unifies all the FPU related header files under a unified, hiearchical naming scheme: - asm/fpu/types.h: FPU related data types, needed for 'struct task_struct', widely included in almost all kernel code, and hence kept as small as possible. - asm/fpu/api.h: FPU related 'public' methods exported to other subsystems. - asm/fpu/internal.h: FPU subsystem internal methods - asm/fpu/xsave.h: XSAVE support internal methods (Also standardize the header guard in asm/fpu/internal.h.) Reviewed-by: -
Ingo Molnar authored
Move the xsave.h header file to the FPU directory as well. Reviewed-by:
-
Ingo Molnar authored
We already have fpu/types.h, move i387.h to fpu/api.h. The file name has become a misnomer anyway: it offers generic FPU APIs, but is not limited to i387 functionality. Reviewed-by:
-
Ingo Molnar authored
Reviewed-by:
-
Ingo Molnar authored
The primary purpose of this function is to clear the current task's FPU before an exec(), to not leak information from the previous task, and to allow the new task to start with freshly initialized FPU registers. Rename the function to reflect this primary purpose. Reviewed-by:
-
Ingo Molnar authored
Migrate this function to pure 'struct fpu' usage. Reviewed-by:
-
Ingo Molnar authored
Migrate this function to pure 'struct fpu' usage. Reviewed-by:
-
Ingo Molnar authored
Migrate this function to pure 'struct fpu' usage. Reviewed-by:
-
Ingo Molnar authored
Migrate this function to pure 'struct fpu' usage. Reviewed-by:
-
Ingo Molnar authored
Migrate this function to pure 'struct fpu' usage. Reviewed-by:
-
Ingo Molnar authored
Migrate this function to pure 'struct fpu' usage. Reviewed-by:
-
Ingo Molnar authored
This helper function is only used in fpu/core.c, move it there. This slightly speeds up compilation. Reviewed-by:
-
Ingo Molnar authored
Migrate this function to pure 'struct fpu' usage. Reviewed-by:
-
Ingo Molnar authored
Migrate this function to pure 'struct fpu' usage. Reviewed-by:
-
Ingo Molnar authored
Migrate this function to pure 'struct fpu' usage. Reviewed-by:
-
Ingo Molnar authored
Migrate this function to pure 'struct fpu' usage. Reviewed-by:
-
Ingo Molnar authored
Also rename it to fpu_want_lazy_restore(), to better indicate that this function just tests whether we can do a lazy restore. (The old name suggested that it was doing the lazy restore, which is not the case.) Reviewed-by:
-
Ingo Molnar authored
Replace task_disable_lazy_fpu_restore() with easier to read open-coded uses: we already update the fpu->last_cpu field explicitly in other cases. (This also removes yet another task_struct using FPU method.) Better explain the fpu::last_cpu field in the structure definition. Reviewed-by:
-
Ingo Molnar authored
Migrate this function to pure 'struct fpu' usage. Reviewed-by:
-
Ingo Molnar authored
Introduce a simple fpu->fpstate_active flag in the fpu context data structure and use that instead of PF_USED_MATH in task->flags. Testing for this flag byte should be slightly more efficient than testing a bit in a bitmask, but the main advantage is that most FPU functions can now be performed on a 'struct fpu' alone, they don't need access to 'struct task_struct' anymore. There's a slight linecount increase, mostly due to the 'fpu' local variables and due to extra comments. The local variables will go away once we move most of the FPU methods to pure 'struct fpu' parameters. Reviewed-by:
-
Ingo Molnar authored
Explain its usage and also document a TODO item. Reviewed-by:
-
Ingo Molnar authored
PF_USED_MATH is used directly, but also in a handful of helper inlines. To ease the elimination of PF_USED_MATH, convert all inline helpers to open-coded PF_USED_MATH usage. Reviewed-by:
-
Ingo Molnar authored
Migrate this function to pure 'struct fpu' usage. Reviewed-by:
-
Ingo Molnar authored
Migrate this function to pure 'struct fpu' usage. Reviewed-by:
-
Ingo Molnar authored
Migrate this function to pure 'struct fpu' usage. Reviewed-by:
-
Ingo Molnar authored
Track the FPU owner context instead of the owner task: this change, together with other changes, will allow in subsequent patches the elimination of 'struct task_struct' usage in various FPU code: we'll be able to use 'struct fpu' only. There's no change in code size: text data bss dec hex filename 13066467 2545248 1626112 17237827 1070743 vmlinux.before 13066467 2545248 1626112 17237827 1070743 vmlinux.after Reviewed-by: -
Ingo Molnar authored
Move it closer to other per-cpu FPU data structures. This also unifies the 32-bit and 64-bit code. Reviewed-by:
-
Ingo Molnar authored
We do this to make the code more readable, and also to be able to eliminate task_struct usage from most of the FPU code. Reviewed-by:
-
Ingo Molnar authored
Start migrating FPU methods towards using 'struct fpu *fpu' directly. __thread_has_fpu() is just a trivial wrapper around fpu->has_fpu, eliminate it. Reviewed-by:
-
Ingo Molnar authored
Ever since the kernel started defaulting to eager FPU switches on modern Intel CPUs it's not been obvious whether a given system is using the lazy or the eager FPU context switching logic. So generate a boot message about which mode the FPU code is in: x86/fpu: Using 'lazy' FPU context switches. or: x86/fpu: Using 'eager' FPU context switches. Reviewed-by:
-
Ingo Molnar authored
Also add a bit of documentation. Reviewed-by:
-
Ingo Molnar authored
Move fpu_copy() where its only user is. Beyond readability this also speeds up compilation, as fpu-internal.h is included in over a dozen .c files. Reviewed-by:
-
Ingo Molnar authored
__save_init_fpu() is just a trivial wrapper around fpu_save_init(). Remove the extra layer of obfuscation. Reviewed-by:
-
Ingo Molnar authored
Instead of open-coded in_kernel_fpu access, Use kernel_fpu_disabled() in interrupted_kernel_fpu_idle(), matching the other kernel_fpu_*() methods. Also add some documentation for in_kernel_fpu. Reviewed-by:
-
Ingo Molnar authored
We are not supposed to call kernel_fpu_disable() if we have not previously enabled it. Also use kernel_fpu_disable()/enable() in the __kernel_fpu_begin/end() primitives, instead of writing to in_kernel_fpu directly, so that we get the debugging checks. Reviewed-by:
-
Ingo Molnar authored
This allows the compiler to inline them and to eliminate them: arch/x86/kernel/fpu/core.o: text data bss dec hex filename 6741 4 8 6753 1a61 core.o.before 6716 4 8 6728 1a48 core.o.after Reviewed-by:
-
