- 15 Sep, 2009 40 commits
-
-
Greg Kroah-Hartman authored
It's all just minor comment spacing issues. This patch fixes up the remaining ones and now the code is checkpatch.pl clean. Cc: Steve Underwood <steveu@coppice.org> Cc: David Rowe <david@rowetel.com> Signed-off-by:Greg Kroah-Hartman <gregkh@suse.de>
-
Kamalesh Babulal authored
next-20090813 randconfig build breaks Discretix SEP driver when configured with CONFIG_PCI=n. drivers/staging/sep/sep_driver.c: In function 'sep_probe': drivers/staging/sep/sep_driver.c:2548: error: implicit declaration of function 'pci_dev_get' This patch adds the dependency on PCI for the DX SEP driver. Signed-off-by:
Kamalesh Babulal <kamalesh@linux.vnet.ibm.com> Cc: Alan Cox <alan@linux.intel.com> Signed-off-by:
-
Alan Cox authored
Whee lots of code vanishes. While we are it note various existing stuff that couldn't work but was ifdeffed in this area. Signed-off-by:
Alan Cox <alan@linux.intel.com> Signed-off-by:
-
Alan Cox authored
While goto can be useful for cleaner cleaning up in C (as Linux sometimes does and I think Linus borrowed stylistically from Amiga) you can overdo it. Here is a fine fine example of when it's overkill Signed-off-by:
-
Alan Cox authored
The SEP time setting stuff can now get a hoover Signed-off-by:
-
Alan Cox authored
Split out the debug dumping functionality. Clean up the rest. For the moment leave the hideous cache flush in there as the code needs fixing to use the dma_map_sg interfaces not its own crazed table functions Signed-off-by:
-
Alan Cox authored
Simple ioctl taking a single numeric argument so ditch the structs and weirdness. While we are it lock it properly and fix the error returns. Signed-off-by:
-
Alan Cox authored
#1: sep->cache_addr is assigned to sep->rar_addr and never changed sep->rar_addr is never assigned after this point #2: sep->cache_bus ditto for sep->rar_bus #3 sep->rar_region_addr is assigned but necer used #4 sep->io_addr is in fact private to the probe function and the same as the reg_addr #5 The remainig sep->io fields are in fact function locals #6 sep->message_shared_area is assigned once from sep->shared_area sep->shared_area does not then change #7 sep->shared_addr and sep->shared_area_addr are the same thing, ditto for the bus addresses. Signed-off-by: -
Alan Cox authored
Use the mutex as a protection for open close rather than leaving it hanging invalidly across userspace. Signed-off-by:
-
Alan Cox authored
Start by removing unused fields and then work this back to eliminate unused chunks of the firmware loading ioctl (ie almost all of it) Also fix the wrong handling of shared allocations and allocate the rar region properly with dma_alloc_coherent not kmalloc, as it is device shared. Signed-off-by:
-
Alan Cox authored
Do these in one batch rather than generate lots of tiny diffs Signed-off-by:
-
Alan Cox authored
Signed-off-by:
-
Alan Cox authored
The DMA handling in the driver is a bit of a catastrophe. Start with the simple things - allocate the shared area properly. Signed-off-by:
-
Alan Cox authored
Signed-off-by:
-
Alan Cox authored
We will need to tackle this in order to begin doing something about the bus handled and shared memory object mess. Signed-off-by:
-
Alan Cox authored
Signed-off-by:
-
Alan Cox authored
Give it a haircut Signed-off-by:
-
Alan Cox authored
We can return NULL - much cleaner Signed-off-by:
-
Alan Cox authored
Various function calls can now be cleaned up Signed-off-by:
-
Alan Cox authored
Move from using a sep_dev global. The workqueue still uses it and we use the pointer in order to know if a device was found. This requires some restructuring as the pci probe and the init module logic are all rather messed up and only worked by luck. Signed-off-by:
-
Alan Cox authored
Don't read the IRQ from the device, the device has no idea what is going on in the full bus topology and remapping above PCI. Use the pdev->irq field. Signed-off-by:
-
Alan Cox authored
Make them more Linuxlike - also favour _bus over _phys Signed-off-by:
-
Alan Cox authored
Open is still completely bogus in this driver but we'll tackle that later - for now fix the bogus API Signed-off-by:
-
Alan Cox authored
Cleaning up the code reveals an obvious thinko Signed-off-by:
-
Alan Cox authored
Exterminate! Exterminate! Exterminate! Signed-off-by:
-
Alan Cox authored
Signed-off-by:
-
Alan Cox authored
Now it is static we can see what code is unused Signed-off-by:
-
Alan Cox authored
Now we have it in one file we can make it all static and see what falls out Signed-off-by:
-
Alan Cox authored
Now we have it trimmed down a bit merge the two pieces so we can clean it up properly. Code moves but no changes in functions. Signed-off-by:
-
Alan Cox authored
We don't need wrappers for this so clean them up Signed-off-by:
-
Alan Cox authored
This doesn't need to be done at runtime so do it at compile time Signed-off-by:
-
Alan Cox authored
Shuffle the functions into a more normal order. Don't however change any of them. Signed-off-by:
-
Alan Cox authored
I suspect these can be killed off entirely Signed-off-by:
-
Alan Cox authored
Remove some rather pointless goto calls Signed-off-by:
-
Alan Cox authored
Again all formatting Signed-off-by:
-
Alan Cox authored
Ok time to indent and get the code in vague shape. No other changes in this patch. Signed-off-by:
-
Alan Cox authored
Signed-off-by:
-
Alan Cox authored
So how about a little helper Signed-off-by:
-
Alan Cox authored
Replace the macros with an inline to get type safety and pass sep_dev instead of the reg pointer Signed-off-by:
-
Alan Cox authored
For now keep the field names matching the variable names Signed-off-by:
-
