Skip to content

L
linux
Switch branch/tag
  1. 18 Sep, 2009 1 commit
    • Theodore Ts'o's avatar
      ext4: Avoid group preallocation for closed files · 50797481
      Theodore Ts'o authored 
      Currently the group preallocation code tries to find a large (512)
free block from which to do per-cpu group allocation for small files.
The problem with this scheme is that it leaves the filesystem horribly
fragmented.  In the worst case, if the filesystem is unmounted and
remounted (after a system shutdown, for example) we forget the fact
that wee were using a particular (now-partially filled) 512 block
extent.  So the next time we try to allocate space for a small file,
we will find *another* completely free 512 block chunk to allocate
small files.  Given that there are 32,768 blocks in a block group,
after 64 iterations of "mount, write one 4k file in a directory,
unmount", the block group will have 64 files, each separated by 511
blocks, and the block group will no longer have any free 512
completely free chunks of blocks for group preallocation space.

So if we try to allocate blocks for a file that has been closed, such
that we know the final size of the file, and the filesystem is not
busy, avoid using group preallocation.
Signed-off-by: default avatar"Theodore Ts'o" <tytso@mit.edu>
      50797481
  3. 10 Aug, 2009 1 commit
    • Theodore Ts'o's avatar
      ext4: Fix bugs in mballoc's stream allocation mode · 4ba74d00
      Theodore Ts'o authored 
      The logic around sbi->s_mb_last_group and sbi->s_mb_last_start was all
screwed up.  These fields were getting unconditionally all the time,
set even when stream allocation had not taken place, and if they were
being used when the file was smaller than s_mb_stream_request, which
is when the allocation should _not_ be doing stream allocation.

Fix this by determining whether or not we stream allocation should
take place once, in ext4_mb_group_or_file(), and setting a flag which
gets used in ext4_mb_regular_allocator() and ext4_mb_use_best_found().
This simplifies the code and assures that we are consistently using
(or not using) the stream allocation logic.
Signed-off-by: default avatar"Theodore Ts'o" <tytso@mit.edu>
      4ba74d00
  5. 09 Aug, 2009 1 commit
  7. 18 Sep, 2009 1 commit
  9. 11 Aug, 2009 3 commits
  11. 28 Jul, 2009 1 commit
  13. 06 Jul, 2009 2 commits
  15. 17 Jul, 2009 2 commits
    • Curt Wohlgemuth's avatar
      ext4: More buffer head reference leaks · 6487a9d3
      Curt Wohlgemuth authored 
      After the patch I posted last week regarding buffer head ref leaks in
no-journal mode, I looked at all the code that uses buffer heads and
searched for more potential leaks.

The patch below fixes the issues I found; these can occur even when a
journal is present.

The change to inode.c fixes a double release if
ext4_journal_get_create_access() fails.

The changes to namei.c are more complicated.  add_dirent_to_buf() will
release the input buffer head EXCEPT when it returns -ENOSPC.  There are
some callers of this routine that don't always do the brelse() in the event
that -ENOSPC is returned.  Unfortunately, to put this fix into ext4_add_entry()
required capturing the return value of make_indexed_dir() and
add_dirent_to_buf().
Signed-off-by: default avatarCurt Wohlgemuth <curtw@google.com>
Signed-off-by: default avatar"Theodore Ts'o" <tytso@mit.edu>
      6487a9d3
    • Jan Kara's avatar
      jbd2: Fail to load a journal if it is too short · f6f50e28
      Jan Kara authored 
      Due to on disk corruption, it can happen that journal is too short. Fail
to load it in such case so that we don't oops somewhere later.
Signed-off-by: default avatarJan Kara <jack@suse.cz>
Signed-off-by: default avatar"Theodore Ts'o" <tytso@mit.edu>
      f6f50e28
  17. 28 Jul, 2009 2 commits
  19. 17 Jul, 2009 1 commit
  21. 16 Sep, 2009 22 commits
  23. 15 Sep, 2009 3 commits
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7