- 28 Jun, 2018 27 commits
-
-
Christian Lütke-Stetzkamp authored
The variable cmd in the function msdc_tune_request is set but never used, so remove it. Signed-off-by:
Christian Lütke-Stetzkamp <christian@lkamp.de> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Christian Lütke-Stetzkamp authored
The macro MAX_BD_PER_GPD is never used, so remove it. Signed-off-by:
-
Christian Lütke-Stetzkamp authored
The macro msdc_retry is never used, so remove it. Signed-off-by:
-
Christian Lütke-Stetzkamp authored
In the current code, msdc_clr_fifo is a macro and just busy waits for a limited amount of time for the fifo clear to finish. That is not correct, the programming manual hits, that the user should wait until the bit is cleared by hardware and not a limited amount of time. So the code is changed to a function, that also relaxes the cpu while busy waiting. Signed-off-by:
-
Christian Lütke-Stetzkamp authored
The BUG_ON() removed by this patch is just a duplicate of a prior BUG_ON() statement. There the condition is just clearer, it checks weather sglen > MAX_BD_NUM and MAX_BD_NUM is equal MAX_BD_PER_GPD. So this statement can be safely removed. Signed-off-by:
-
Christian Lütke-Stetzkamp authored
The variable num in msdc_dma_setup is only used for a BUG_ON statement, so it can be removed by inlining the condition. Signed-off-by:
-
Christian Lütke-Stetzkamp authored
The field sglen from struct msdc_dma is once set and never read, so remove it. Signed-off-by:
-
Christian Lütke-Stetzkamp authored
The field sg from struct msdc_dma is once set and never read, so remove it. Signed-off-by:
-
Christian Lütke-Stetzkamp authored
Current code uses two functions for dma setup, msdc_dma_config and msdc_dma_setup. By now msdc_dma_setup is nearly empty and mainly calls msdc_dma_config, so the later one can be inline into the first one. While doing this there is also some refactoring done. Signed-off-by:
-
Christian Lütke-Stetzkamp authored
The field mode of struct msdc_dma has no remaining use, so remove it. Signed-off-by:
-
Christian Lütke-Stetzkamp authored
The driver currently only uses DMA linked mode and the upstream driver does the same, so remove the basic mode code. Signed-off-by:
-
Christian Lütke-Stetzkamp authored
Current code has structures for all the registers of the device, but these are never used and there are also masks for all of them, so these structures do not contain any useful information. Signed-off-by:
-
Christian Lütke-Stetzkamp authored
The macro sdr_write8 is never used, so remove it. Signed-off-by:
-
Christian Lütke-Stetzkamp authored
The macro sdr_read8 is never used, so remove it. Signed-off-by:
-
Christian Lütke-Stetzkamp authored
The current code uses a macro (sdr_read32) for reading from hardware, but it is only a readl, so replace it to get nearer to upstream code. Signed-off-by:
-
Christian Lütke-Stetzkamp authored
The current code uses a macro (sdr_write32) for writing to hardware, but it is only a writel with switched arguments, so replace it to get nearer to upstream code. Signed-off-by:
-
Christian Lütke-Stetzkamp authored
The macro msdc_rxfifocnt is never used, so remove it. Signed-off-by:
-
Christian Lütke-Stetzkamp authored
The macro msdc_txfifocnt is never used, so remove it. Signed-off-by:
-
Christian Lütke-Stetzkamp authored
The macro msdc_fifo_read32 is never used, so remove it. Signed-off-by:
-
Christian Lütke-Stetzkamp authored
The macro msdc_fifo_write32 is never used, so remove it. Signed-off-by:
-
Christian Lütke-Stetzkamp authored
The macro msdc_fifo_read8 is never used, so remove it. Signed-off-by:
-
Christian Lütke-Stetzkamp authored
The macro msdc_fifo_write8 is never used, so remove it. Signed-off-by:
-
Christian Lütke-Stetzkamp authored
The variable resp in msdc_command_resp is once set and never read, delete it. Signed-off-by:
-
Sergio Paracuellos authored
This commit replaces ENOSYS return with ENOTSUPP silencing the following checkpatch warning: WARNING: ENOSYS means 'invalid syscall nr' and nothing else Signed-off-by:
Sergio Paracuellos <sergio.paracuellos@gmail.com> Signed-off-by:
-
Sergio Paracuellos authored
Messages when memory allocation fails are not needed at all and checkpatch script complains about them. Remove one in this driver code. Signed-off-by:
-
Sergio Paracuellos authored
This commit replaces all 'unsigned' type declarations along the driver code in favour of the preferred one 'unsigned int'. This also silence checkpatch script warnings about this issue. Signed-off-by:
-
Sergio Paracuellos authored
It's good to have SPDX identifiers in driver files to make it easier to audit the kernel tree for correct licenses. Fix up the one of staging mt7621-pinctrl file to have a proper SPDX identifier, based on the license text in the file itself. The SPDX identifier is a legally binding shorthand, which can be used instead of the full boiler plate text. Signed-off-by:
-
- 26 Jun, 2018 13 commits
-
-
Michael Straube authored
This satisfies a checkpatch warning and is the preferred method for notating the license. The SPDX identifier is a legally binding shorthand, which can be used instead of the full boiler plate text. Signed-off-by:
Michael Straube <straube.linux@gmail.com> Signed-off-by:
-
John Whitmore authored
Simple spelling correction. Signed-off-by:
John Whitmore <johnfwhitmore@gmail.com> Signed-off-by:
-
John Whitmore authored
Corrected the coding style of if statement. Signed-off-by:
-
John Whitmore authored
Removed the unrequired braces from single statement blocks - Coding Style. Signed-off-by:
-
John Whitmore authored
Where possible truncation of block comments to the 80 character length preferred by the coding style. In a previous version of this commit some of the comments were contentious so those have not been touched in this version. Signed-off-by:
-
John Whitmore authored
Removed an extra indentation from the code of the various case options in a switch statement. Signed-off-by:
-
John Whitmore authored
Some of the comment blocks are commening out code so have been left for the moment. Signed-off-by:
-
Janani Sankara Babu authored
This patch replaces the comparison of var to NULL with !var Signed-off-by:
Janani Sankara Babu <jananis37@gmail.com> Signed-off-by:
-
Janani Sankara Babu authored
This patch removes the comaprison to bool value in the code Signed-off-by:
-
Janani Sankara Babu authored
This patch removes comparison to False and boolean values in the code which can be written as !var Signed-off-by:
-
Fabian Bläse authored
This patch improves spacing according to the coding guidelines, mainly around braces. This patch fixes errors reported by checkpatch. Signed-off-by:
Fabian Bläse <fabian.blaese@fau.de> Signed-off-by:
Maximilian Ott <maximilian.o.ott@fau.de> Signed-off-by:
-
Fabian Bläse authored
This patch improves spacing according to the coding guidelines, mainly around braces. This patch fixes errors reported by checkpatch. Signed-off-by:
-
Jia-Ju Bai authored
The driver may sleep with holding a spinlock. The function call paths (from bottom to top) in Linux-4.16.7 are: [FUNC] kzalloc(GFP_KERNEL) drivers/staging/rtl8188eu/core/rtw_cmd.c, 502: kzalloc in rtw_disassoc_cmd drivers/staging/rtl8188eu/core/rtw_ioctl_set.c, 256: rtw_disassoc_cmd in rtw_set_802_11_ssid drivers/staging/rtl8188eu/core/rtw_ioctl_set.c, 235: spin_lock_bh in rtw_set_802_11_ssid [FUNC] kzalloc(GFP_KERNEL) drivers/staging/rtl8188eu/core/rtw_cmd.c, 502: kzalloc in rtw_disassoc_cmd drivers/staging/rtl8188eu/core/rtw_ioctl_set.c, 352: rtw_disassoc_cmd in rtw_set_802_11_infrastructure_mode drivers/staging/rtl8188eu/core/rtw_ioctl_set.c, 336: spin_lock_bh in rtw_set_802_11_infrastructure_mode To fix this bug, GFP_KERNEL is replaced with GFP_ATOMIC. This bug is found by my static analysis tool (DSAC-2) and checked by my code review. Signed-off-by:
Jia-Ju Bai <baijiaju1990@gmail.com> Signed-off-by:
-
