1. 04 Jan, 2020 1 commit
  2. 30 Dec, 2019 1 commit
  3. 29 Dec, 2019 1 commit
  4. 27 Dec, 2019 1 commit
  5. 23 Dec, 2019 1 commit
    • Takashi Iwai's avatar
      ALSA: hda - Apply sync-write workaround to old Intel platforms, too · c366b3db
      Takashi Iwai authored
      Klaus Ethgen reported occasional high CPU usages in his system that
      seem caused by HD-audio driver.  The perf output revealed that it's
      in the unsolicited event handling in the workqueue, and the problem
      seems triggered by some communication stall between the controller and
      the codec at the runtime or system resume.
      
      Actually a similar phenomenon was seen in the past for other Intel
      platforms, and we already applied the workaround to enforce sync-write
      for CORB/RIRB verbs for Skylake and newer chipsets (commit
      2756d914 "ALSA: hda - Fix intermittent CORB/RIRB stall on Intel
      chips").  Fortunately, the same workaround is applicable to the old
      chipset, and the experiment showed the positive effect.
      
      Based on the experiment result, this patch enables the sync-write
      workaround for all Intel chipsets.  The only reason I hesitated to
      apply this workaround was about the possibly slightly higher CPU usage.
      But if the lack of sync causes a much severer problem even for quite
      old chip, we should think this would be necessary for all Intel chips.
      Reported-by: default avatarKlaus Ethgen <Klaus@ethgen.ch>
      Cc: <stable@vger.kernel.org>
      Link: https://lore.kernel.org/r/20191223171833.GA17053@chua
      Link: https://lore.kernel.org/r/20191223221816.32572-1-tiwai@suse.deSigned-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      c366b3db
  6. 21 Dec, 2019 1 commit
  7. 20 Dec, 2019 1 commit
  8. 19 Dec, 2019 1 commit
  9. 18 Dec, 2019 1 commit
    • Hui Wang's avatar
      ALSA: usb-audio: set the interface format after resume on Dell WD19 · 92adc96f
      Hui Wang authored
      Recently we found the headset-mic on the Dell Dock WD19 doesn't work
      anymore after s3 (s2i or deep), this problem could be workarounded by
      closing (pcm_close) the app and then reopening (pcm_open) the app, so
      this bug is not easy to be detected by users.
      
      When problem happens, retire_capture_urb() could still be called
      periodically, but the size of captured data is always 0, it could be
      a firmware bug on the dock. Anyway I found after resuming, the
      snd_usb_pcm_prepare() will be called, and if we forcibly run
      set_format() to set the interface and its endpoint, the capture
      size will be normal again. This problem and workaound also apply to
      playback.
      
      To fix it in the kernel, add a quirk to let set_format() run
      forcibly once after resume.
      Signed-off-by: default avatarHui Wang <hui.wang@canonical.com>
      Cc: <stable@vger.kernel.org>
      Link: https://lore.kernel.org/r/20191218132650.6303-1-hui.wang@canonical.comSigned-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      92adc96f
  10. 17 Dec, 2019 1 commit
  11. 16 Dec, 2019 2 commits
  12. 14 Dec, 2019 5 commits
  13. 11 Dec, 2019 1 commit
  14. 10 Dec, 2019 8 commits
  15. 09 Dec, 2019 4 commits
  16. 08 Dec, 2019 1 commit
    • Olof Johansson's avatar
      ALSA: echoaudio: simplify get_audio_levels · c08f0a92
      Olof Johansson authored
      The loop optimizer seems to go astray here, and produces some warnings
      that don't seem valid.
      
      Still, the code can be simplified -- just clear the whole array at the
      beginning, and fill in whatever values are valid on the platform.
      
      Warnings before this change (GCC 8.2.0 ARM allmodconfig):
      
      In file included from ../sound/pci/echoaudio/gina24.c:115:
      ../sound/pci/echoaudio/echoaudio.c: In function 'snd_echo_vumeters_get':
      ../sound/pci/echoaudio/echoaudio_dsp.c:647:9: warning: iteration 1073741824 invokes undefined behavior [-Waggressive-loop-optimizations]
      In file included from ../sound/pci/echoaudio/layla24.c:112:
      ../sound/pci/echoaudio/echoaudio.c: In function 'snd_echo_vumeters_get':
      ../sound/pci/echoaudio/echoaudio_dsp.c:658:9: warning: iteration 1073741824 invokes undefined behavior [-Waggressive-loop-optimizations]
      ../sound/pci/echoaudio/echoaudio_dsp.c:647:9: warning: iteration 1073741824 invokes undefined behavior [-Waggressive-loop-optimizations]
      Signed-off-by: default avatarOlof Johansson <olof@lixom.net>
      Link: https://lore.kernel.org/r/20191207224953.25944-1-olof@lixom.netSigned-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      c08f0a92
  17. 04 Dec, 2019 3 commits
  18. 03 Dec, 2019 3 commits
  19. 29 Nov, 2019 3 commits