- 13 Nov, 2012 40 commits
-
-
Mark Einon authored
"The cpu return address and the DMA bus master address are both guaranteed to be aligned to the smallest PAGE_SIZE order which is greater than or equal to the requested size." There are several places in the et131x.c code where these addresses are aligned to a 4k boundary after a call to dma_alloc_coherent(), needlessly. Remove these alignment offset calculations, and the et131x_align_allocated_memory() call which is only used for 4k alignments. Signed-off-by:
Mark Einon <mark.einon@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Mark Einon authored
In et131x_rx_dma_memory_alloc(), we loop over fbr_entries - the values of fbr_align and fbr_chunksize calculated in the loop do not depend on the loop counter and are the same for all loop iterations. Take the calculations of these values out of the loop, as we only need to calculate them once per loop, not once per loop iteration. Signed-off-by:
-
Johan Meiring authored
This fixes one of the two instances of an 80+ char line in the file. Fixing the other instance would have decreased the readability of the code, in my opinion. Signed-off-by:
Johan Meiring <johanmeiring@gmail.com> Signed-off-by:
-
Johan Meiring authored
This uses linux/io.h instead of asm/io.h and cleans up an 80+ character issue. Signed-off-by:
-
Stefan Hajnoczi authored
The CONFIG_LINE6_USB_DEBUG option is no longer relevant since dyndbg dev_dbg() is now used instead of a compile-time decision whether to enable debug messages or not. Signed-off-by:
Stefan Hajnoczi <stefanha@gmail.com> Signed-off-by:
-
Stefan Hajnoczi authored
The DEBUG_MESSAGES() macro is no longer needed since dev_dbg() is now used for debug messages. Signed-off-by:
-
Stefan Hajnoczi authored
The dyndbg feature allows dev_dbg() calls to be enabled/disabled at runtime and is therefore more convenient than static debug log messages. Use dev_dbg() instead of the line6-specific DEBUG_MESSAGES() macro. Signed-off-by:
-
Stefan Hajnoczi authored
Signed-off-by:
-
Stefan Hajnoczi authored
Signed-off-by:
-
Stefan Hajnoczi authored
The LED value is an int, so replace strict_strtol() with kstrtoint(). It's safe to pass in the actual variable instead of a local temporary because strto*() doesn't write to the result unless the function returns success. Signed-off-by:
-
Stefan Hajnoczi authored
There are a few instances of 80+ character lines in playback.c. Two instances are just because of a useless comment "this is somewhat paranoid", so drop the comment. Other instances are straightforward line wrapping. Signed-off-by:
-
Stefan Hajnoczi authored
Signed-off-by:
-
Stefan Hajnoczi authored
Signed-off-by:
-
Stefan Hajnoczi authored
Checkpatch warns when quoted strings are split across lines. The rationale is that quoted strings should be left on a single line so that grep works. (The 80 character line limit does not apply to quoted strings.) Signed-off-by:
-
Stefan Hajnoczi authored
Signed-off-by:
-
YAMANE Toshiaki authored
Modified to eliminate the deep nesting. Signed-off-by:
YAMANE Toshiaki <yamanetoshi@gmail.com> Signed-off-by:
-
YAMANE Toshiaki authored
Modified to eliminate the deep nesting. Signed-off-by:
-
YAMANE Toshiaki authored
Modified to eliminate the deep nesting and redundant description. Signed-off-by:
-
YAMANE Toshiaki authored
Fixed a description of the procedure call dev_dbg(). Signed-off-by:
-
YAMANE Toshiaki authored
fixed below checkpatch warnings. - WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ... - WARNING: Prefer netdev_info(netdev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO ... - WARNING: Prefer netdev_dbg(netdev, ... then dev_dbg(dev, ... then pr_debug(... to printk(KERN_DEBUG ... - WARNING: Prefer netdev_warn(netdev, ... then dev_warn(dev, ... then pr_warn(... to printk(KERN_WARNING ... and add pr_fmt. Signed-off-by:
-
Adil Mujeeb authored
Fixed checpatch.pl reported ERRORs (excluding WARNING of line over 80 characters) Signed-off-by:
Adil Mujeeb <mujeeb.adil@gmail.com> Acked-by:
Pavel Machek <pavel@ucw.cz> Signed-off-by:
-
Adil Mujeeb authored
Removed printk tracing call Signed-off-by:
-
Adil Mujeeb authored
Fixed checkpatch.pl reported ERRORs Signed-off-by:
-
Adil Mujeeb authored
Removed unnecessary printk and pr_debug tracing calls Signed-off-by:
-
Kumar Amit Mehta authored
fix for few error messages as reported by checkpatch.pl Signed-off-by:
Kumar Amit Mehta <gmate.amit@gmail.com> Signed-off-by:
-
Kumar Amit Mehta authored
fixed few error messages as reported by checkpatch.pl Signed-off-by:
-
Harvey Yang authored
If probe returns with error, the kthread is still alive even when all usbip modules unloaded. So do cleanups in error handler. Signed-off-by:
harvey.yang <harvey.huawei.yang@gmail.com> Signed-off-by:
-
Aaro Koskinen authored
Remaining vb_table.h data can be trivially made const. Signed-off-by:
Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by:
-
Aaro Koskinen authored
Make Tap4 data const and adjust functions accordingly. Signed-off-by:
-
Aaro Koskinen authored
Access XGI340_AGPReg directly and make it const. Signed-off-by:
-
Aaro Koskinen authored
Inline constant values that are used only once. Signed-off-by:
-
Aaro Koskinen authored
Access XGI340_CR6B directly and make it const. Signed-off-by:
-
Aaro Koskinen authored
In-line constants that are used only once. Signed-off-by:
-
Aaro Koskinen authored
Delete unused data. Signed-off-by:
-
Aaro Koskinen authored
Access XGI330_ModeResInfo directly and make it const. Signed-off-by:
-
Aaro Koskinen authored
Access XGI330_ScreenOffset directly and make it const. Signed-off-by:
-
Aaro Koskinen authored
Access XGI_VCLKData and XGI_VBVCLKData directly and make them const. Signed-off-by:
-
Aaro Koskinen authored
Access XGI340_ECLKData directly and make it const. Signed-off-by:
-
Aaro Koskinen authored
Eliminate dummy zero read-only global data. Signed-off-by:
-
Aaro Koskinen authored
Access XGI_UpdateCRT1Table directly and make it const. Signed-off-by:
-
