Commit 763806e0 by Julien Muchembled

client: revert incorrect memory optimization

Since commit d2d77437 ("client: make the cache
tolerant to late invalidations when the entry is in the history queue"),
invalidated items became current again when they were moved to the history
queue, which was wrong for 2 reasons:
- only the last items of _oid_dict values may have next_tid=None,
- and for such items, they could be wrongly reused when caching the real
  current data.
parent 5f0c93f5
...@@ -121,7 +121,7 @@ class ClientCache(object): ...@@ -121,7 +121,7 @@ class ClientCache(object):
item.expire = self._time + self._life_time item.expire = self._time + self._life_time
else: else:
self._size -= len(item.data) self._size -= len(item.data)
item.data = item.next_tid = None item.data = None
if self._history_size < self._max_history_size: if self._history_size < self._max_history_size:
self._history_size += 1 self._history_size += 1
else: else:
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or sign in to comment