master: document bug in STOPPING state

c61e2fb0 · Julien Muchembled · b2d13516 · c61e2fb0
Commit c61e2fb0 authored Oct 14, 2019 by Julien Muchembled
Show whitespace changes
Inline Side-by-side

Showing with 3 additions and 0 deletions

neo/master/app.py neo/master/app.py +3 -0

No files found.
--- a/neo/master/app.py
+++ b/neo/master/app.py
@@ -497,6 +497,9 @@ class Application(BaseApplication):

    def shutdown(self):
        """Close all connections and exit"""
+        # BUG: Broken if the cluster was not in RUNNING state.
+        #      For example, storage nodes identifies as RUNNING
+        #      and are told to start operation.
        self.changeClusterState(ClusterStates.STOPPING)
        # Marking a fictional storage node as starting operation blocks any
        # request to start a new transaction. Do this way has 2 advantages: