Commits · 4b6c1387c42957782df91bda03e79a95d15242f3 · nexedi / neoppod

27 Apr, 2011 3 commits

connection: make close always call handler (connectionClosed or connectionFailed) · 4b6c1387

Julien Muchembled authored Apr 27, 2011

Main reason is that it's difficult to know in advance which side really closes
the connection. Network events can be chaotic and this could lead to many race
conditions.
Thus, handler can be used to update any database that is somewhat redundant
to the connection status, i.e. node status usually. Safely and less duplicated
code.

This change is motivated by recurrent random failures during election.
An example of race condition was that 2 fully connected master could close the
extra connection (the primary -> secondary one) at the same time.

In order to stabilize lower-level code and start with reliable election process,
code has also been simplified to not care about node states. All connections
without exception are closed at the end of the election and states are then
updated 1 by 1 by identification handler.
Note that during election, there may be 2 connection per node, which makes
difficult to update node states by connectionFailed/connectionClosed events.

timeoutExpired & peerBroken are dropped as they are unused for the moment.
A new API should be designed so that connectionClosed know the reason of the
close.
BROKEN state becomes unused.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@2732 71dcc9de-d417-0410-9af5-da40c76e7ee4

4b6c1387

storage: do not log all store event during normal run · 35f0a5bf
Julien Muchembled authored Apr 27, 2011
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@2731 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
35f0a5bf
tests: enable packet logger only when a NEO test is run · ab6e1806
Julien Muchembled authored Apr 27, 2011
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@2730 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
ab6e1806

21 Apr, 2011 4 commits

Update tests against r2728 (added assertion in Connection.abort) · b265df3e
Julien Muchembled authored Apr 21, 2011
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@2729 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
b265df3e

Do not try to send notifications on closed connections · f9b5cea4

Julien Muchembled authored Apr 21, 2011

Now we can assert that abort is not called when it shouldn't be.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@2728 71dcc9de-d417-0410-9af5-da40c76e7ee4

f9b5cea4

Do not answer pings on aborted connections · 81cbbeeb
Julien Muchembled authored Apr 21, 2011
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@2727 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
81cbbeeb

logs: fix packet names of responses · 25ca11ce

Julien Muchembled authored Apr 21, 2011

The contained the request name twice. Example:
  #0x00000000 AnswerPrimaryMasterPrimaryMaster  to  None (127.0.0.1:34804)

git-svn-id: https://svn.erp5.org/repos/neo/trunk@2726 71dcc9de-d417-0410-9af5-da40c76e7ee4

25ca11ce

20 Apr, 2011 8 commits

tests: extend bdb/rpdb2 debuggers to help debugging a set of processes · 49962b18

Julien Muchembled authored Apr 20, 2011

This adds a dependency to 'psutil', which is required anyway to fix
NEOProcess.isAlive

git-svn-id: https://svn.erp5.org/repos/neo/trunk@2725 71dcc9de-d417-0410-9af5-da40c76e7ee4

49962b18

debug: extract winpdb code from pdbHandler to a reusable function for tests · 11a323bd
Julien Muchembled authored Apr 20, 2011
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@2724 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
11a323bd

tests: ignore NEO_TESTS_ADAPTER in tests requiring a SQL database · 7b54a6b3

Julien Muchembled authored Apr 20, 2011

Although some tests of testStorage and testPack don't need a SQL database,
this patch applies to the whole class for simplicity's sake.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@2723 71dcc9de-d417-0410-9af5-da40c76e7ee4

7b54a6b3

election: fix a case where the primary has wrong state information about another master · e41dbfef
Julien Muchembled authored Apr 20, 2011
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@2722 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
e41dbfef

tests: make sure NEOCluster.stop kills all children, even if one failed · 4836a4b4

Julien Muchembled authored Apr 20, 2011

This fixes possible suite freeze due to unreleased locks.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@2721 71dcc9de-d417-0410-9af5-da40c76e7ee4

4836a4b4

master: make setNodeState return appropriate message when state is unchanged · 829f9b4c
Julien Muchembled authored Apr 20, 2011
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@2720 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
829f9b4c
tests: implement default __str__ & __repr__ for Mock objects · 27c0b505
Julien Muchembled authored Apr 20, 2011
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@2719 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
27c0b505
tests: prevent child from killing other children at exit · 13e86665
Julien Muchembled authored Apr 20, 2011
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@2718 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
13e86665

13 Apr, 2011 2 commits
- tests: new environment variable to specify default adapter · d0c8b63b
  Julien Muchembled authored Apr 13, 2011
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@2717 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
  d0c8b63b
- Add URL of paper about Multi-Queue algorithm · e9477a54
  Julien Muchembled authored Apr 13, 2011
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@2716 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
  e9477a54
12 Apr, 2011 7 commits

client: give an example to adjust level of cached items according to their size · 44aa0d6d
Julien Muchembled authored Apr 12, 2011
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@2715 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
44aa0d6d
client: fix _cache attribute of Storage · 4f2d91c4
Julien Muchembled authored Apr 12, 2011
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@2714 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
4f2d91c4
Update tests against previous changes to client cache · c0b9f5b4
Julien Muchembled authored Apr 12, 2011
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@2713 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
c0b9f5b4
client: remove duplicate 'snapshot_tid' parameter of Application.load · 2c17284f
Julien Muchembled authored Apr 12, 2011
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@2712 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
2c17284f

Rewrite storage cache of client · edde1fe3

Julien Muchembled authored Apr 12, 2011

- Stop using a list of (in)validated tid (hence removal of RevisionIndex),
  because it can't work in all cases and would even cause memory leaks.
  For example, this bug could lead to ConflictError with a single client.
  Fixit it also requires that database backends always return the next serial.
- Several performance improvements. The most important one is when the latest
  version of an object is cached: it inherits the access counter of the
  previous one (for the same oid), which gets in turn its counter reset.
- Do not waste CPU evaluating the real size taken by an entry in memory.
  Just use 'len' on the value (which is always a pickle data, i.e. a string).

git-svn-id: https://svn.erp5.org/repos/neo/trunk@2711 71dcc9de-d417-0410-9af5-da40c76e7ee4

edde1fe3

client: rename mq.py to cache.py before rewriting it · 240c94b3
Julien Muchembled authored Apr 12, 2011
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@2710 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
240c94b3

Fix unit tests broken by r2703 · d5be36a3

Julien Muchembled authored Apr 12, 2011

git-svn-id: https://svn.erp5.org/repos/neo/trunk@2709 71dcc9de-d417-0410-9af5-da40c76e7ee4

d5be36a3

07 Apr, 2011 9 commits

tests: new ClusterPdb.sync method to place sync points · 41c4ce1f
Julien Muchembled authored Apr 07, 2011
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@2708 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
41c4ce1f
master: simplify connectionLost code in ClientElectionHandler · 4621d1b8
Julien Muchembled authored Apr 07, 2011
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@2707 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
4621d1b8

Small optimizations · 0be7e00c

Julien Muchembled authored Apr 07, 2011

git-svn-id: https://svn.erp5.org/repos/neo/trunk@2706 71dcc9de-d417-0410-9af5-da40c76e7ee4

0be7e00c

Fix several typos in comments/(doc)strings · 96a7a90e
Julien Muchembled authored Apr 07, 2011
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@2705 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
96a7a90e

logs: remove duplicate logged information when a transaction begins · fd17fda6

Julien Muchembled authored Apr 07, 2011

The node is already displayed in 'repr' of the transaction.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@2704 71dcc9de-d417-0410-9af5-da40c76e7ee4

fd17fda6

logs: show source address/port when a connection is set up · 2361b151
Julien Muchembled authored Apr 07, 2011
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@2703 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
2361b151

logs: make sure every line is prefixed for easy merge of several log files · ef692021

Julien Muchembled authored Apr 07, 2011

Merging several log files becomes as easy as:

$ sort -sk 1,2 *.log |less

git-svn-id: https://svn.erp5.org/repos/neo/trunk@2702 71dcc9de-d417-0410-9af5-da40c76e7ee4

ef692021

logs: increase time resolution (.1 ms instead of 1 ms) · 38bdc708
Julien Muchembled authored Apr 07, 2011
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@2701 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
38bdc708

logs: show handler used by connections · e87f0d61

Julien Muchembled authored Apr 07, 2011

To avoid too long lines, 'closed' value is displayed as int instead of boolean.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@2700 71dcc9de-d417-0410-9af5-da40c76e7ee4

e87f0d61

31 Mar, 2011 2 commits
- runner: fix ZeroDivisionError when no test is run · 21d83bd9
  Julien Muchembled authored Mar 31, 2011
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@2699 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
  21d83bd9
- Add some compatibility with ZODB 3.9 · 47eb8436
  Julien Muchembled authored Mar 31, 2011
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@2698 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
  47eb8436
24 Mar, 2011 5 commits
- tests: disallow assert{Not}Equals and fail{If,Unless}Equal (except in tests.zodb) · 07d19338
  Julien Muchembled authored Mar 24, 2011
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@2697 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
  07d19338
- tests: assertNotEquals -> assertNotEqual · 37bf8620
  Julien Muchembled authored Mar 24, 2011
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@2696 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
  37bf8620
- tests: assertEquals -> assertEqual · 82149414
  Julien Muchembled authored Mar 24, 2011
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@2695 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
  82149414
- tests: use assert{False,True} instead of assertEqual(..., {False,True}) · 8b7702b7
  Julien Muchembled authored Mar 24, 2011
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@2694 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
  8b7702b7
- tests: Mock objects can't be passed to assert(Not)Equal · 4458b7e5
  Julien Muchembled authored Mar 24, 2011
```
This fixes tests on Python 2.7

git-svn-id: https://svn.erp5.org/repos/neo/trunk@2693 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
  4458b7e5