Commits · ae810cfb8bb68f810c59b45947fb63a7abf2304a · nexedi / neoppod

01 Oct, 2009 17 commits
- Because the purpose of an handler is to *handle* (packets), remove the 'handle' · ae810cfb
  Grégory Wisniewski authored Oct 01, 2009
```
prefix from everywhere.


git-svn-id: https://svn.erp5.org/repos/neo/trunk@1350 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
  ae810cfb
- Remove the unused 'InternalError' code/exception/handler. · a53b51dd
  Grégory Wisniewski authored Oct 01, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1349 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
  a53b51dd
- Switch those methods to private. · 30666e41
  Grégory Wisniewski authored Oct 01, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1348 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
  30666e41
- Handle this error with an exception. · 85c4f63a
  Grégory Wisniewski authored Oct 01, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1347 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
  85c4f63a
- Move the comparison method to the right class (Node instead of NodeManager) · aef4e539
  Grégory Wisniewski authored Oct 01, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1346 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
  aef4e539
- Fix bad indentation in tests modules. · 912e0a4d
  Grégory Wisniewski authored Oct 01, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1345 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
  912e0a4d
- Clean import of test module (thanks to pylint). · e3926ad4
  Grégory Wisniewski authored Oct 01, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1344 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
  e3926ad4
- Use new Enum class for packet types. Drop the old Enum, this job is done. · ef7eedd3
  Grégory Wisniewski authored Oct 01, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1343 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
  ef7eedd3
- Call super class' __init__ method and hard define attributes. · cf37fdd3
  Grégory Wisniewski authored Oct 01, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1342 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
  cf37fdd3
- Use Enum class for error codes. · 802aadb8
  Grégory Wisniewski authored Oct 01, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1341 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
  802aadb8
- Allow compare an enum item with None. · 2c361c13
  Grégory Wisniewski authored Oct 01, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1340 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
  2c361c13
- As previous commits, use new Enum class for cell states. · 8f08613c
  Grégory Wisniewski authored Oct 01, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1339 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
  8f08613c
- Use new Enum class for Node States and remove unused imports. · 6d746894
  Grégory Wisniewski authored Oct 01, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1338 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
  6d746894
- Remove overriden method definition. · 01fab3d2
  Grégory Wisniewski authored Oct 01, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1337 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
  01fab3d2
- Fix wrong variable name. · 4fb147bf
  Grégory Wisniewski authored Oct 01, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1336 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
  4fb147bf
- Remove some unused imports. · f281c6a5
  Grégory Wisniewski authored Oct 01, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1335 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
  f281c6a5
- Apply new Enum class to node types. Use each time the 'NodeTypes' symbol import · 04d5bcc6
  Grégory Wisniewski authored Oct 01, 2009
```
to avoid full module.


git-svn-id: https://svn.erp5.org/repos/neo/trunk@1334 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
  04d5bcc6
30 Sep, 2009 18 commits

Define a new Enum class that don't fails with static analysies. This allow · 7358c9bf

Grégory Wisniewski authored Sep 30, 2009

gather good results from tools like 'pylint'.
Use this for cluster state for now, others will follow.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1333 71dcc9de-d417-0410-9af5-da40c76e7ee4

7358c9bf

Remove old configuration-file-related definitions. · 911111de
Grégory Wisniewski authored Sep 30, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1332 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
911111de

Define get(Client|Server)List on event manager and use them to simplify the · ba56e027

Grégory Wisniewski authored Sep 30, 2009

logic in the master application, mainly during election stage.


git-svn-id: https://svn.erp5.org/repos/neo/trunk@1331 71dcc9de-d417-0410-9af5-da40c76e7ee4

ba56e027

Define is<State> methods on Cell class and use them. · 5b2d787a
Grégory Wisniewski authored Sep 30, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1330 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
5b2d787a

Node got an asTuple() method that return it's content as required by protocol · bc534916

Grégory Wisniewski authored Sep 30, 2009

packet encoder (for node information notifications)


git-svn-id: https://svn.erp5.org/repos/neo/trunk@1329 71dcc9de-d417-0410-9af5-da40c76e7ee4

bc534916

Remove useless type/except, the address tuple is no more splitted before pass to · 00840676
Grégory Wisniewski authored Sep 30, 2009
```
the packet encoder.


git-svn-id: https://svn.erp5.org/repos/neo/trunk@1328 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
00840676

Use anytime is possible the is<State>() and set<State> available in Node class. · 27b900a5

Grégory Wisniewski authored Sep 30, 2009

Remove all (now useless) imports from protocol module.


git-svn-id: https://svn.erp5.org/repos/neo/trunk@1327 71dcc9de-d417-0410-9af5-da40c76e7ee4

27b900a5

Add isIdentified() on Node class that check if an UUID is set on this node. The · 71e1beef

Grégory Wisniewski authored Sep 30, 2009

purpose is to replace the so often used <node.getUUID() is not None> pattern.


git-svn-id: https://svn.erp5.org/repos/neo/trunk@1326 71dcc9de-d417-0410-9af5-da40c76e7ee4

71e1beef

Add set<state> and is<state> helper methods in Node class to avoid many imports · eb810f88

Grégory Wisniewski authored Sep 30, 2009

from protocol module and clarify the source code. Those definitions will be
gradualy used everywhere in NEO.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1325 71dcc9de-d417-0410-9af5-da40c76e7ee4

eb810f88

Each time a unknown node is registered into the manager, the state is defaulted · 0d1c4b07
Grégory Wisniewski authored Sep 30, 2009
```
to 'UNKNOWN'.


git-svn-id: https://svn.erp5.org/repos/neo/trunk@1324 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
0d1c4b07

Change NodeManager.log() implementation, display one node per line with (or · 9111aa13

Grégory Wisniewski authored Sep 30, 2009

without) it's UUID and bind address if available. Implement '__gt__' to sort
nodes per UUID by default.
Reduce log verbosity by displaying nodes only one time per manager update.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1323 71dcc9de-d417-0410-9af5-da40c76e7ee4

9111aa13

Fix method name. · cc2d5e26

Grégory Wisniewski authored Sep 30, 2009


git-svn-id: https://svn.erp5.org/repos/neo/trunk@1322 71dcc9de-d417-0410-9af5-da40c76e7ee4

cc2d5e26

Remove unused imports. · 4eeabcbf

Grégory Wisniewski authored Sep 30, 2009


git-svn-id: https://svn.erp5.org/repos/neo/trunk@1321 71dcc9de-d417-0410-9af5-da40c76e7ee4

4eeabcbf

To follows changes in r1317, replace 'server' by 'address' for consistency. · 8e2b08de
Grégory Wisniewski authored Sep 30, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1320 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
8e2b08de
As for previous commit, replace calls of getXXXNodeList() with getXXXList(). · 36555d9a
Grégory Wisniewski authored Sep 30, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1319 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
36555d9a
Replace calls of 'getNodeByXXX' with 'getByXXX' because 'Node' is implied by the · 57e5e7f8
Grégory Wisniewski authored Sep 30, 2009
```
node manager.


git-svn-id: https://svn.erp5.org/repos/neo/trunk@1318 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
57e5e7f8

Partial rewrite of Node and NodeManager classes: · 86819c9c

Grégory Wisniewski authored Sep 30, 2009

* Manager now index per node type and node state
* Use set() instead of list() to ensure node unicity
* Rename 'server' attribute to 'address' for consistency
* Remove 'filter' parameter from clear(), because it's never used.
* Update tests 


git-svn-id: https://svn.erp5.org/repos/neo/trunk@1317 71dcc9de-d417-0410-9af5-da40c76e7ee4

86819c9c

Remove useless imports. · 053eaa8b

Grégory Wisniewski authored Sep 30, 2009


git-svn-id: https://svn.erp5.org/repos/neo/trunk@1316 71dcc9de-d417-0410-9af5-da40c76e7ee4

053eaa8b

29 Sep, 2009 4 commits

Remove useless checks (already done in registerXXX()) · 340e7808
Grégory Wisniewski authored Sep 29, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1315 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
340e7808
Use isMaster() instead of check the node type. · 3ee69f4e
Grégory Wisniewski authored Sep 29, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1314 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
3ee69f4e

Remove manager getter/setter from Node class and require it in the constructor · dd02fa4c

Grégory Wisniewski authored Sep 29, 2009

since a node must always be registered to the manager. Remove *args parameters,
positional arguments are no more allowed for node creation.
Fix wrong definition of dict in createFromNodeType.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1313 71dcc9de-d417-0410-9af5-da40c76e7ee4

dd02fa4c

Add create<NodeType> methods on the NodeManager, now node creation is only done · 68835978

Grégory Wisniewski authored Sep 29, 2009

through those methods and node registration is automatic. There is no more need
to import Node classes directly, so remove all related imports.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1312 71dcc9de-d417-0410-9af5-da40c76e7ee4

68835978

24 Sep, 2009 1 commit
- Use class-check to known the node type. · 76671a6f
  Grégory Wisniewski authored Sep 24, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1311 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
  76671a6f