1. 13 Jun, 2017 6 commits
  2. 06 Jun, 2017 4 commits
  3. 05 Jun, 2017 1 commit
    • Tomáš Peterka's avatar
      Revert "[test] Do not check non-function commands" · 75650e2c
      Tomáš Peterka authored
      This reverts commit 889711ed
      
      This approach to solve checking of commands by logging is wrong. It can lead to malicious commands being executed so this test is no longer reliable.
      
      We just should not test issued commands - test should use an isolated environment and then inspect the impact.
      
      /reviewed-on !15
      75650e2c
  4. 02 Jun, 2017 2 commits
  5. 26 May, 2017 1 commit
  6. 22 May, 2017 1 commit
  7. 11 May, 2017 1 commit
  8. 27 Feb, 2017 1 commit
    • Vincent Pelletier's avatar
      slapos.grid.SlapObject: Get rid noisy and pointless comment. · 1d4e3aed
      Vincent Pelletier authored
      Comment duplicates the url. It is available 3 lines below, thank you very
      much.
      Comment assumes resulting file is actually intended for viewer to edit it,
      which is wrong.
      
      So just leave the comment out altogether, as it does not bring any value.
      Also, allows simplifying code.
      1d4e3aed
  9. 30 Nov, 2016 1 commit
  10. 10 Nov, 2016 2 commits
  11. 03 Nov, 2016 2 commits
  12. 25 Oct, 2016 3 commits
  13. 24 Oct, 2016 1 commit
  14. 19 Oct, 2016 2 commits
  15. 12 Oct, 2016 3 commits
    • Alain Takoudjou's avatar
    • Sebastien Robin's avatar
      svcbackend: raise exception if supervisord is failing · 7b59f9a4
      Sebastien Robin authored
      errors will be much more visible
      7b59f9a4
    • Sebastien Robin's avatar
      svcbackend: explicitely call the executable instead of using Popen 'executable' keyword · 14979297
      Sebastien Robin authored
      Some testnodes were failing more or less randomly while calling "slapos node instance".
      On failing nodes, unlike other ones, there was this unexpected log:
      
      2016-10-06 15:35:18 slapos[11671] INFO Processing computer partitions...
      2016-10-06 15:35:18 slapos[11671] INFO Launching supervisord with clean environment.
      2016-10-06 15:35:18 slapos[11671] INFO Could not find platform independent libraries <prefix>
      2016-10-06 15:35:18 slapos[11671] INFO Could not find platform dependent libraries <exec_prefix>
      2016-10-06 15:35:18 slapos[11671] INFO Consider setting $PYTHONHOME to <prefix>[:<exec_prefix>]
      2016-10-06 15:35:18 slapos[11671] INFO ImportError: No module named site
      2016-10-06 15:35:18 slapos[11671] WARNING Supervisord unknown problem:
      2016-10-06 15:35:18 slapos[11671] INFO Processing Computer Partition test0-0.
      
      Then slapgrid was later failing with :
      
      slapgrid_cp :   File "/opt/slapgrid/75e907b4c1523ecfa2aa210ec2754db4/eggs/supervisor-3.3.1-py2.7.egg/supervisor/xmlrpc.py", line 521, in connect
      slapgrid_cp :     self.sock.connect(self.socketfile)
      slapgrid_cp :   File "/opt/slapos/rebootstrap/parts/python2.7/lib/python2.7/socket.py", line 228, in meth
      slapgrid_cp :     return getattr(self._sock,name)(*args)
      slapgrid_cp : error: [Errno 2] No such file or directory
      
      But the initial suspect logs sounds be the original issue that is the source
      of next ones.
      
      So it looks like supervisord was not able to start at all.
      
      After playing with subprocess.Popen, is sounds not a good idea to play
      with the keyword 'executable'. It looks like not always be strictly equivalent
      to a replacement of the first argument of the first Popen args. It's much better
      to directly set the process we want to call in the invocation list :
      - it avoid to rely on a feature that is "very seldom needed" as we see
        in subprocess documentation
      - it makes the code much readable, it avoid the guy reading the
        code wasting time understanding that the invocation_list is not
        really what is going to be executed.
      14979297
  16. 10 Oct, 2016 1 commit
  17. 07 Oct, 2016 1 commit
  18. 05 Oct, 2016 5 commits
  19. 29 Sep, 2016 1 commit
  20. 28 Sep, 2016 1 commit