1. 14 Jan, 2019 3 commits
  2. 07 Jan, 2019 1 commit
  3. 02 Jan, 2019 1 commit
    • Thomas Gambier's avatar
      Make IPv6 on tap optionnal and put only 1 IPv6 address on the tap itself. · 40ee3280
      Thomas Gambier authored
      tap_ipv6 option let you chose if you want IPv6 on the taps or not. Some
      customers may decide to have only IPv4 inside their VMs.
      
      We put only 1 address on the tap itself (e.g.
      2001:67c:1254:e:89:69b0:ffff:ffff/128 instead of
      2001:67c:1254:e:89:69b0:ffff:ffff/96) otherwise, when we assign the
      address 2001:67c:1254:e:89:69b0::/96 inside the VM, the address has
      "dadfailed" status (dad = "Duplicate Address Detection"). The problem
      appears only with address "0" (ending in ::) but not with others
      addresses. We had 2 solutions:
       * put only one address on the tap (the solution we choose)
       * forbid address "0" inside the VM
      
      The chosen solution has the advantage that the host machine won't
      answer the ping on behalf of the VM since the tap has only 1 address
      (its own).
      
      /cc @alain.takoudjou
      
      /reviewed-on !86
      40ee3280
  4. 28 Dec, 2018 3 commits
  5. 27 Dec, 2018 4 commits
    • Thomas Gambier's avatar
      CLEANUP: use assertNotEqual instead of assertNotEquals · 812d00c4
      Thomas Gambier authored
      assertNotEquals is deprecated since 3.2 (see https://docs.python.org/3.7/library/unittest.html#deprecated-aliases)
      This is a followup of 175b5788
      812d00c4
    • Jérome Perrin's avatar
      collect: tolerate "No sensors found!" error running sensors · 42b2b5ef
      Jérome Perrin authored
      /reviewed-on !81
      42b2b5ef
    • Jérome Perrin's avatar
      tests/slapgrid: make test more deterministic · d4d89cce
      Jérome Perrin authored
      `test_one_failing_daemon_in_service_will_bang_with_watchdog` often fail with:
      
      ```
      ======================================================================
      FAIL: test_one_failing_daemon_in_service_will_bang_with_watchdog (slapos.tests.slapgrid.TestSlapgridCPWithMasterWatchdog)
      ----------------------------------------------------------------------
      Traceback (most recent call last):
        File "/srv/slapgrid/slappart9/srv/testnode/bpy/inst/test0-0/parts/slapos.core/slapos/tests/slapgrid.py", line 907, in test_one_failing_daemon_in_service_will_bang_with_watchdog
          'etc', 'software_release', 'worked', '.slapos-retention-lock-delay'])
        File "/srv/slapgrid/slappart9/srv/testnode/bpy/soft/5082e1741ad09c0910ec59bf9feae300/eggs/six-1.11.0-py2.7.egg/six.py", line 673, in assertCountEqual
          return getattr(self, _assertCountEqual)(*args, **kwargs)
      AssertionError: Element counts were not equal:
      First has 1, Second has 0:  'crashed'
      First has 1, Second has 0:  'launched'
      ```
      
      This test uses a service that will create files `launched` and `crashed` files
      when running, and just after telling supervisor to start the service test
      inspects the directory content.
      If service had time to start, then files are created, otherwise they are not.
      
      Change the service to wait for a delay before creating the files to reduce the
      change of race condition here.
      
      /reviewed-on !82
      d4d89cce
    • Jérome Perrin's avatar
      tests/slapproxy: give more time to slapproxy to start · a92ef82b
      Jérome Perrin authored
      Tests are sometimes failing with:
      
      ```
      ======================================================================
      FAIL: testForwardToMasterInList (slapos.tests.slapproxy.TestMultiMasterSupport)
      ----------------------------------------------------------------------
      Traceback (most recent call last):
        File "/srv/slapgrid/slappart9/srv/testnode/byq/inst/test0-0/parts/slapos.core/slapos/tests/slapproxy/__init__.py", line 1003, in setUp
          self.startExternalProxy()
        File "/srv/slapgrid/slappart9/srv/testnode/byq/inst/test0-0/parts/slapos.core/slapos/tests/slapproxy/__init__.py", line 1050, in startExternalProxy
          self.fail('Could not start external proxy.')
      AssertionError: Could not start external proxy.
      
      ```
      
      especially on `COMP-2203-3Nodes-ERP5PROJECT2`. I logged on that machine and check the tests, it was really a problem that this slapproxy needs more than the `(20 * .1) = 2` seconds this tests waits before concluding that slap proxy could not start.
      
      Change the waiting loop to wait more each time. With this approach the max waiting time is 20 seconds.
      
      /reviewed-on !83
      a92ef82b
  6. 26 Dec, 2018 2 commits
  7. 20 Dec, 2018 5 commits
  8. 17 Dec, 2018 4 commits
  9. 16 Dec, 2018 3 commits
  10. 14 Dec, 2018 2 commits
  11. 11 Dec, 2018 2 commits
  12. 06 Dec, 2018 1 commit
  13. 04 Dec, 2018 1 commit
  14. 03 Dec, 2018 3 commits
    • Thomas Gambier's avatar
      Add tests for default argument · 0c0b92fb
      Thomas Gambier authored
      0c0b92fb
    • Thomas Gambier's avatar
      CLEANUP: remove trailing spaces · 9df6ecd8
      Thomas Gambier authored
      9df6ecd8
    • Thomas Gambier's avatar
      BUGFIX: fix c931d60c · 3b8cf767
      Thomas Gambier authored
      After c931d60c, default options were changed and we didn't want that.
      
      Rewrite the code so that we have a clearer scheme:
       * all options of format are listed as FormatConfig attributes with default values
       * all values present in configuration file (.cfg) erase the previous options
       * all values present in command line erase the previous options
      
      We use the special default argparse.SUPPRESS that removes totally the arg from arg dict so that only PRESENT options erase something
      3b8cf767
  15. 30 Nov, 2018 2 commits
  16. 27 Nov, 2018 1 commit
  17. 26 Nov, 2018 2 commits