Skip to content
  • This project
    • Loading...
  • Sign in

nexedi / slapos.package

Go to a project
Toggle navigation
Toggle navigation pinning
  • Projects
  • Groups
  • Snippets
  • Help
  • Project
  • Activity
  • Repository
  • Pipelines
  • Graphs
  • Issues 0
  • Merge Requests 6
  • Wiki
  • Network
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Merged
Merge Request !28 opened 2017-11-20 09:51:29 UTC by Łukasz Nowak@luke

[playbook] Use mktemp for temporary location

Instead of chosing arbitrary directory and removing, often not accessible directories, use standard mktemp for temporary location.

Edited 2017-11-20 10:48:04 UTC
Request to merge luke:feature/diff-playbook-mktemp into master
×

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch https://lab.nexedi.com/luke/slapos.package.git feature/diff-playbook-mktemp
git checkout -b luke/slapos.package-feature/diff-playbook-mktemp FETCH_HEAD

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git checkout master
git merge --no-ff luke/slapos.package-feature/diff-playbook-mktemp

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Merged

The changes were merged into master.

  • Discussion 2
  • Commits 1
  • Changes 1
  • {{ resolvedDiscussionCount }}/{{ discussionCount }} {{ resolvedCountText }} resolved
  • @luke Łukasz Nowak
    @luke commented 2017-11-20 09:52:07 UTC
    Developer

    @rafael and @alain.takoudjou please take a look. I use this tool in order to validate shacache playbook and this speeds it up and removes a lot of "Access denied" messages.

  • @luke Łukasz Nowak
    @luke

    mentioned in commit 514e713a

    2017-11-20 10:47:54 UTC

    mentioned in commit 514e713a

    Toggle commit list
  • @rafael Rafael Monnerat
    @rafael

    Status changed to merged

    2017-11-20 10:47:55 UTC

    Status changed to merged

    Toggle commit list
  • @rafael Rafael Monnerat
    @rafael commented 2017-11-20 10:48:04 UTC
    Owner

    Merci...

  • Write
  • Preview
Styling with Markdown is supported
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
  • Please register or sign in to post a comment
Assignee
No assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
3
3 participants
Reference: nexedi/slapos.package!28
×

Revert this commit

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.
×

Cherry-pick this commit

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备14008524号