1. 22 Apr, 2020 4 commits
  2. 15 Apr, 2020 1 commit
  3. 31 Mar, 2020 1 commit
  4. 30 Mar, 2020 1 commit
    • Dmitry Blinov's avatar
      set -e for shell commands · 2f92b674
      Dmitry Blinov authored
      If not set, the commands in the middle of custom configure-command,
      pre-build, post-build etc can fail without resulting in SystemError
      for user and without stopping cmmi process, which thus can formally
      succeed despite being misconfigured or in some cases with the code
      not even built.
      This is because when executing a multiline command, only the exit
      status of the last one actually gets caught by check_call().
      Setting -e makes debugging easier by allowing shell to terminate
      mid-way if errors (non-zero exit status) occur.
      -e only covers 'simple commands', and does not affect 'if' tests
      and more complex cases where non-zero exit status is expected to
      occur normally.
      Detailed description of -e effects can be seen in the POSIX
  5. 12 Dec, 2019 1 commit
  6. 10 Dec, 2019 1 commit
    • Jérome Perrin's avatar
      shared: Fix recovery after an interrupted build · 0bb65331
      Jérome Perrin authored
      When build process is interrupted (like when the buildout process
      terminated by SIGKILL), building with shared leave the system in a state
      that looks like installation succeeded, so next execution will assume
      the part was properly installed.
      The behavior was something like this:
          if isSharedPartSignatureOK():
      and when program is terminated during build step, the signature is
      The fix is to write signature later, algorithm becomes:
          if isSharedPartSignatureOK():
      /reviewed-on !10
  7. 05 Dec, 2019 1 commit
  8. 02 Oct, 2019 4 commits
  9. 01 Oct, 2019 1 commit
  10. 30 Sep, 2019 1 commit
    • Jérome Perrin's avatar
      Support multiple paths for shared · 3cd08544
      Jérome Perrin authored
      This will allow nested slapos where the inner slapos can re-use shared
      parts from outer slapos, but not write into the outer shared parts.
      For compatibility reasons, the syntax of the buildout option changed,
      instead of the old ${buildout:shared-parts} that use to be one path, we
      now use ${buildout:shared-part-list} as a \n separated list of paths.
      All paths can be used to lookup existing parts, only the last one can be
      used to install new parts.
      There is no compatibility with the old option as it was not used much,
      only in profiles which were not really compatible with shared options.
  11. 26 Sep, 2019 3 commits
  12. 25 Sep, 2019 1 commit
  13. 30 Nov, 2018 3 commits
  14. 29 Oct, 2018 2 commits
  15. 16 Oct, 2018 2 commits
    • Jérome Perrin's avatar
      Do not set any TMP environment variables · 9ca803bb
      Jérome Perrin authored
      This reverts daa833ea ( !3 ) and extend it to not set `$TMP` either.
      De facto, setting only `$TMP` was never effective ( see also [#20120530-132221B](https://nexedi.erp5.net/bug_module/20120530-132221B) ) and as we saw in !3 (comment 67059) it causes more harm than good.
      The conclusion so far is that environment variables related to temporary files should be handled by the parent process. The parent process is responsible for providing a directory short enough so that we can create unix sockets in `$TMPDIR`  and to clean up this directory afterwards.
      In a pure buildout it could be:
      tmpdir=$(mktemp -d)
      trap 'rm -rf $tmpdir' SIGINT SIGTERM
      TEMP=$tmpdir TMPDIR=$tmpdir TMP=$tmpdir buildout
      rm -rf $tmpdir
      /reviewed-on !8
    • Jérome Perrin's avatar
      Don't set TMP environment variable · f101b03b
      Jérome Perrin authored
      It was inconsistent to only set TMP and not TEMP / TEMPDIR. In the case
      of slapos, it should be set by slapos node software
      Most installation seem to cleanup tmp properly, so the use case cleaning
      up seem not critical.
      This TMP was also used to know what new files have been created, by
      considering files newer that the creation date of this directory.
      Compare the file dates with the creation of the source directory instead
      ( xxx__compile__ )
  16. 04 Oct, 2018 1 commit
  17. 02 Oct, 2018 2 commits
  18. 19 Sep, 2018 1 commit
  19. 18 Sep, 2018 1 commit
  20. 27 Aug, 2018 2 commits
  21. 22 Aug, 2018 3 commits
  22. 21 Aug, 2018 2 commits
  23. 20 Aug, 2018 1 commit