ok
Would you please also update slapos.toolbox version in stack/slapos.cfg as well?
I have another MR slapos!1532 in which I continue my work, feel free to upgrade the egg yourself if you want to have it already available on master branch.
Indeed, I see 0.141 and 0.142 are already in pypi https://pypi.org/project/slapos.toolbox/#history
So I close this MR.
Łukasz Nowak (8e269cd3) at 15 Feb 14:20
Release 0.142
Łukasz Nowak (8e269cd3) at 15 Feb 14:20
Release 0.142
Łukasz Nowak (cbecd39f) at 15 Feb 14:19
check_surykatka_json: Fix support for missing expiration_date
... and 1 more commit
Łukasz Nowak (112bd00e) at 15 Feb 08:47
Release 0.141
Łukasz Nowak (112bd00e) at 15 Feb 08:47
Release 0.141
Łukasz Nowak (4b864b82) at 15 Feb 08:44
check_surykatka_json: Implement whois checks
Hello @tomo. I need updated slapos.toolbox to be released so that unittests of new ors-amarisoft work correctly under testnodes. So could you please make the release, like we did in !128 (merged) ?
Thanks beforehand,
Kirill
/cc @jhuge, @lu.xu, @xavier_thompson, @Daetalus
When testing is True we do not have hardware around and only check generated configuration files. Most lopcomm promises were already skipping themselves under testing=True environment, but check_lopcomm_config_log and check_lopcomm_stats_log were missing testing checks. This leads to test failures when trying to test ors-amarisoft with Lopcomm driver in my upcoming work via [1] e.g. as
================================================================================
Error with promises for the following partitions:
TestENB_Lopcomm4-0[enb]: Promise 'RU1-stats-log.py' failed with output: Not subscribed
-> Fix it by making sure testing==True
checks are present in all
promises related to lopcomm.
P.S. in current ors-amarisoft Lopcomm driver is not tested at all: even
though we have testFDD-LOPCOMM.py there[2] python unittest discover ...
does not pick up test files with dash in their name. This is also
true for all other dashed test files. Currently only testTDD.py and
testFDD.py are run during the tests there.
[1] https://lab.nexedi.com/kirr/slapos/blob/5b8ec2b3/software/ors-amarisoft/test/test.py
[2] https://lab.nexedi.com/nexedi/slapos/tree/15871bbf/software/ors-amarisoft/test
/cc @jhuge, @lu.xu, @tomo, @xavier_thompson, @Daetalus
Kirill Smelkov (48726608) at 18 Jan 10:32
promise/plugin/check_lopcomm_*: Skip all promises when testing=True
Thanks, Joanne.
Hello Kirill, this is OK with me.
When testing is True we do not have hardware around and only check generated configuration files. Most lopcomm promises were already skipping themselves under testing=True environment, but check_lopcomm_config_log and check_lopcomm_stats_log were missing testing checks. This leads to test failures when trying to test ors-amarisoft with Lopcomm driver in my upcoming work via [1] e.g. as
================================================================================
Error with promises for the following partitions:
TestENB_Lopcomm4-0[enb]: Promise 'RU1-stats-log.py' failed with output: Not subscribed
-> Fix it by making sure testing==True
checks are present in all
promises related to lopcomm.
P.S. in current ors-amarisoft Lopcomm driver is not tested at all: even
though we have testFDD-LOPCOMM.py there[2] python unittest discover ...
does not pick up test files with dash in their name. This is also
true for all other dashed test files. Currently only testTDD.py and
testFDD.py are run during the tests there.
[1] https://lab.nexedi.com/kirr/slapos/blob/5b8ec2b3/software/ors-amarisoft/test/test.py
[2] https://lab.nexedi.com/nexedi/slapos/tree/15871bbf/software/ors-amarisoft/test
/cc @jhuge, @lu.xu, @tomo, @xavier_thompson, @Daetalus