Migrate old promises to plugin promise format
Migrate all promises used by caddy-frontend SR to plugin promise format
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
slapos/test/promise/plugin/test_check_error_on_apache_log.py 0 → 100644
17 # This program is distributed in the hope that it will be useful, 18 # but WITHOUT ANY WARRANTY; without even the implied warranty of 19 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 20 # GNU General Public License for more details. 21 # 22 # You should have received a copy of the GNU General Public License 23 # along with this program; if not, write to the Free Software 24 # Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. 25 # 26 ############################################################################## 27 28 from slapos.test.promise.plugin import TestPromisePluginMixin 29 import os 30 from slapos.test.promise import data 31 32 class TestCheckErrorOnApacheLog(TestPromisePluginMixin): -
I'm not requesting changes, but
TestPromisePluginMixin
is not really aMixin
according to https://en.wikipedia.org/wiki/Mixin#In_Python maybePromisePluginTestCase
would have been a better name -
OK @jerome , I'll check and change it in another commit (as I also need to change others tests).
-
-
added 2 commits
Toggle commit list -
-
Toggle commit list
-
-
-
-
-
-
added 2 commits
Toggle commit list -
-
unmarked as a Work In Progress
Toggle commit list -
merged
Toggle commit list -
Apparently this introduced a regression
====================================================================== FAIL: test_ipv6_is_faster (slapos.test.promise.plugin.test_check_re6st_optimal_status.TestCheckRe6stOptimalStatus) ---------------------------------------------------------------------- Traceback (most recent call last): File "/srv/slapgrid/slappart7/srv/testnode/ij/inst/test0-0/parts/slapos.toolbox/slapos/test/promise/plugin/test_check_re6st_optimal_status.py", line 65, in test_ipv6_is_faster self.assertEqual(last_message, "OK: IPv4 reachable, IPv6 reachable") AssertionError: u'OK: IPv4 unreachable, IPv6 reachable' != 'OK: IPv4 reachable, IPv6 reachable'
-
@jerome, I'll fix it thanks.
-
Since 0d084fb6 we are back to
[PASS] SLAPOS-EGG-TEST: 862 Tests, 0 Errors, 0 Failures, 29 Skips
, thanks @alain.takoudjou !
-
Please register or sign in to post a comment