Commit c15db7c1 authored by Jérome Perrin's avatar Jérome Perrin

Revert "slaprunner: ..."

This reverts commit 2cc61477.

Now we now, without "futures" egg, gunicorn refuses to start:

    Error: class uri 'gunicorn.workers.gthread.ThreadWorker' invalid or not found:

    [Traceback (most recent call last):
      File "/srv/slapgrid/slappart14/srv/testnode/cqc/inst/test0-0/tmp/soft/8c22f5a21e7f016f38916f098ab2339b/eggs/gunicorn-19.7.1-py2.7.egg/gunicorn/util.py", line 134, in load_class
	mod = import_module('.'.join(components))
      File "/srv/slapgrid/slappart14/srv/testnode/cqc/inst/test0-0/tmp/shared/python2.7/8d8826883d34c5a7ec7a5b8c187d89c9/lib/python2.7/importlib/__init__.py", line 37, in import_module
	__import__(name)
      File "/srv/slapgrid/slappart14/srv/testnode/cqc/inst/test0-0/tmp/soft/8c22f5a21e7f016f38916f098ab2339b/eggs/gunicorn-19.7.1-py2.7.egg/gunicorn/workers/gthread.py", line 37, in <module>
	""")
    RuntimeError:
	You need to install the 'futures' package to use this worker with this
	Python version.
parent ebe69d83
Pipeline #8028 failed with stage
in 0 seconds
......@@ -152,6 +152,7 @@ eggs =
slapos.recipe.build
slapos.toolbox[flask_auth]
gunicorn==19.7.1
futures
${slapos-cookbook:eggs}
slapos.core # listed explicitly for scripts generation
......@@ -164,6 +165,7 @@ eggs +=
[versions]
Flask-Auth = 0.85
cns.recipe.symlink = 0.2.3
futures = 3.0.5
gitdb = 0.6.4
gunicorn = 19.7.1
prettytable = 0.7.2
......
  • If we need more reference, I saved a snapshot corresponding to this failing test on testnode log directory here, we can see this traceback in .s0_gunicorn-ecc24f35487878e4f7bfe089b1d29e2f.log

    /cc @jm @bminusl @alain.takoudjou

  • Thanks.

    If we upgrade gunicorn to 19.10.0, it has:

    if sys.version_info[0] < 3:
        extra_require['gthread'] = ['futures']

    (I hoped it uses the ...; python_version... syntax) Could we then replace:

      gunicorn==19.7.1
      futures

    with:

      gunicorn['gthread']

    And software-py3.cfg wouldn't have to do:

    eggs -=
      futures
  • Updating to > 19.10.0 and using gunicorn['gthread'] seems a good approach.

    I think we should avoid it and have the dependencies listed in setup.py, but probably using ...;python_version... in buildout profile would work as well.

    edit for a typo: add /it/ in avoid it*

    Edited by Jérome Perrin
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment