done with:

     npm install
     git ls-files | grep -v '\/unstable\/' | xargs ./node_modules/.bin/eclint fix
     git ls-files | grep buildout.hash.cfg | xargs ./update-hash

there was a mistake in 2de4c80f, we
should sleep for the min duration of these two

because we anyway has never used log, but just use stderr ourput.

in HAProxy 2.0, httpclose has the same meaning as forceclose, that is deprecated.

The recommended approach is now to generate a font.conf file using
slapos.recipe.template:jinja2 since font.conf now needs entries for all
directories containing fonts.

Use NameWidth=* so that long filenames are never truncated

Use SuppressColumnSorting to disable the ablity to sort so that we can
wget -r all the logs for local analysis

See nexedi/slapos!739

Also use better argument names. The function is used in pbs recipe and
was wrongly removed in 569439d5 commit.

See nexedi/slapos!739

The '.lock' suffix is automatically added by lockfile. See
https://opendev.org/openstack/pylockfile/src/tag/0.12.2/lockfile/__init__.py#L218

See nexedi/slapos!739

This is not used, and probably buggy

Since the first version, this have been writing config files in binary
mode, but these are really text files.

If for example the ip changed, this recipe needs to re-generate
configuration files.

Use the first ipv6 to generate the URL

This was relying on a slapos patch allowing to serialize sets, but
that was not useful, because we had to encode the sets ourselves in the
profiles.

This mysql_update service retries every 30 seconds, but what usually
happens is that it starts at same time as mariadb, make a first attempt
at connect which fails because mariadb is not ready, sleep for 30
seconds, reties and succeed. Which is not efficient because we don't
need to wait for so long.
Instead of sleeping for 30 seconds between each retries, start with a
short delay and increase each time, but not more than 30 seconds.

As found by jm@nexedi.com :

>>> with open('/dev/null') as f:
...   subprocess.check_call(('echo', 'foo'), stdout=f)

echo: write error: Bad file descriptor

[duplicity] has at least 2 issues:
- use os.chdir
- creation of paths outside of location

If pgdata already exists, then postgres recipe will not update or install anything when buildout will run. This result to no configuration or wrapper updated if configuration changes.

For example this change:  29d1ed68  the path of `posgtres bin` is now in shared folder, then impossible to run postgres service anymore because path was not updated by buildout in wrapper.

/reviewed-on nexedi/slapos!703

This recipe already use all options defined in buildout for substitution
in the erp5testnode.cfg.in

hash-existing-files list all the files used for hash that are not
handled by buildout. For those files, the hash is calculated as soon as
the __init__ function so that if there is a change in those files,
buildout will remove the existing wrapper (it will uninstall the
section) and replace it with the new wrapper.

--user=root is redundant and it will break with MariaDB 10.4

Remove method `generateHashFromFiles` in all file `test.py`, import it from `slapos.recipe.librecipe`.

/reviewed-on nexedi/slapos!617