Problem: Travis security on PRs break jobs

Solution: avoid using encrypted variables when on PR

Problem: Travis security on PRs break jobs
Solution: avoid using encrypted variables when on PR
a7e4ad61 · Godefroid Chapelle · d685efdf · a7e4ad61 · a7e4ad61 · a7e4ad61
Commit a7e4ad61 authored Mar 12, 2021 by Godefroid Chapelle
Showing with 3 additions and 1 deletion

.travis.yml .travis.yml +1 -1

.travis/docker_login_on_non_pull_requests.sh .travis/docker_login_on_non_pull_requests.sh +1 -0

news/travis-pr.develop news/travis-pr.develop +1 -0

No files found.
--- a/.travis.yml
+++ b/.travis.yml
@@ -64,7 +64,7 @@ notifications:
    - buildout-development@googlegroups.com
 script:
-    - echo "$DOCKER_PASSWORD" | docker login -u "$DOCKER_USERNAME" --password-stdin
+    - 'if [ "$TRAVIS_PULL_REQUEST" = "false" ]; then bash ./.travis/docker_login_on_non_pull_requests.sh; fi'
    - ./ci_build.sh
 env:

--- a/.travis/docker_login_on_non_pull_requests.sh
+++ b/.travis/docker_login_on_non_pull_requests.sh
+echo "$DOCKER_PASSWORD" | docker login -u "$DOCKER_USERNAME" --password-stdin
--- a/news/travis-pr.develop
+++ b/news/travis-pr.develop
+Avoid broken jobs on Travis because of security on PRs