Damaged XML only raise when changing instance state

master/product/Vifib/tests/testVifibSlapComputerGetComputerPartitionList.py

@@ -711,22 +711,44 @@ class TestVifibSlapComputerGetComputerPartitionList(TestVifibSlapWebServiceMixin
     software_instance.edit(connection_xml="")
 
   def stepDamageSoftwareInstanceSlaXml(self, sequence, **kw):
-    software_instance = self.portal.portal_catalog.getResultValue(
+    instance = self.portal.portal_catalog.getResultValue(
         uid=sequence['software_instance_uid'])
-    software_instance.edit(sla_xml="""
-    DAMAGED<BAD?xml XMLversion="1.0" encoding="utf-8"?>""")
+    if instance.getPortalType() == "Software Instance":
+      shared = False
+    elif instance.getPortalType() == "Slave Instance":
+      shared = True
+    else:
+      raise NotImplementedError
+    self.assertRaises(ValidationFailed, instance.requestStart,
+        software_release=instance.getRootSoftwareReleaseUrl(),
+        instance_xml=instance.getTextContent(),
+        software_type=instance.getSourceReference(),
+        sla_xml="""DAMAGED<BAD?xml XMLversion="1.0" encoding="utf-8"?>""",
+        shared=shared,
+        )
 
   def stepDamageSoftwareInstanceConnectionXml(self, sequence, **kw):
-    software_instance = self.portal.portal_catalog.getResultValue(
+    instance = self.portal.portal_catalog.getResultValue(
         uid=sequence['software_instance_uid'])
-    software_instance.edit(connection_xml="""
+    instance.edit(connection_xml="""
     DAMAGED<BAD?xml XMLversion="1.0" encoding="utf-8"?>""")
 
   def stepDamageSoftwareInstanceXml(self, sequence, **kw):
-    software_instance = self.portal.portal_catalog.getResultValue(
+    instance = self.portal.portal_catalog.getResultValue(
         uid=sequence['software_instance_uid'])
-    self.assertRaises(ValidationFailed, software_instance.edit,
-      text_content="""DAMAGED<BAD?xml XMLversion="1.0" encoding="utf-8"?>""")
+    if instance.getPortalType() == "Software Instance":
+      shared = False
+    elif instance.getPortalType() == "Slave Instance":
+      shared = True
+    else:
+      raise NotImplementedError
+    self.assertRaises(ValidationFailed, instance.requestStart,
+        software_release=instance.getRootSoftwareReleaseUrl(),
+        instance_xml="""DAMAGED<BAD?xml XMLversion="1.0" encoding="utf-8"?>""",
+        software_type=instance.getSourceReference(),
+        sla_xml=instance.getSlaXml(),
+        shared=shared,
+        )
 
   def stepCheckDamageSoftwareInstanceSiteConsistency(self, sequence, **kw):
     software_instance = self.portal.portal_catalog.getResultValue(