[hal_json_style] Set correct HTTP STATUS for invalid form while rendering

/reviewed-on nexedi/erp5!593

bt5/erp5_hal_json_style/SkinTemplateItem/portal_skins/erp5_hal_json_style/Base_renderForm.py

-# request.RESPONSE.setStatus(200)
 form = getattr(context, form_id)
+
+request = REQUEST or context.REQUEST
+
+# HAL JSON uses HTTP codes to communicate what the payload represents
+if request.get('field_errors', None):
+  # HTTP400 means invalid form
+  request.RESPONSE.setStatus(400)
+
 return context.ERP5Document_getHateoas(form=form, mode='form')

bt5/erp5_hal_json_style/SkinTemplateItem/portal_skins/erp5_hal_json_style/Base_renderForm.xml

@@ -50,7 +50,7 @@
         </item>
         <item>
             <key> <string>_params</string> </key>
-            <value> <string>form_id</string> </value>
+            <value> <string>form_id, REQUEST=None</string> </value>
         </item>
         <item>
             <key> <string>id</string> </key>

bt5/erp5_web_renderjs_ui_test/PathTemplateItem/portal_tests/renderjs_ui_page_templates_zuite/testFormDialogWorkflowError.zpt

@@ -43,6 +43,9 @@
 </tr>
 <!-- Do not fill anything to provoke form validation failure -->
 <tal:block metal:use-macro="here/Zuite_CommonTemplateForRenderjsUi/macros/submit_dialog" />
+<tal:block tal:define="notification_configuration python: {'class': 'error', 'text': 'Input data has errors.'}">
+  <tal:block metal:use-macro="here/Zuite_CommonTemplateForRenderjsUi/macros/wait_for_notification" />
+</tal:block>
 <tr><td>waitForElementPresent</td>
     <td>//div[@data-gadget-scope="field_your_custom_workflow_variable"]/div/span</td><td></td></tr>
 <tr><td>assertText</td>
@@ -60,8 +63,7 @@
 
 <!-- Wait for the notification to appear. We cannot use verifyText because the button
      is there all the time. It gets text assigned and is shown asynchronously later. -->
-<tal:block tal:define="notification_configuration python: {'class': 'success',
-                                                           'text': 'Status changed.'}">
+<tal:block tal:define="notification_configuration python: {'class': 'success', 'text': 'Status changed.'}">
   <tal:block metal:use-macro="here/Zuite_CommonTemplateForRenderjsUi/macros/wait_for_notification" />
 </tal:block>
 </tbody></table>