Set by #{link_to_member(@project,@merge_request.merge_user,avatar: true)}
to be merged automatically when the pipeline succeeds.
.remove-message-pipes
%ul
%li
%span
=succeed'.'do
The changes will be merged into #{link_to@merge_request.target_branch,namespace_project_commits_path(@project.namespace,@project,@merge_request.target_branch),class: "label-branch"}
=link_to"open an issue to resolve them later",new_namespace_project_issue_path(@project.namespace,@project,merge_request_to_resolve_discussions_of: @merge_request.iid)
@@ -169,6 +169,14 @@ Clicking on the Monitoring button will display a new page, showing up to the las
...
@@ -169,6 +169,14 @@ Clicking on the Monitoring button will display a new page, showing up to the las
8 hours of performance data. It may take a minute or two for data to appear
8 hours of performance data. It may take a minute or two for data to appear
after initial deployment.
after initial deployment.
## Determining performance impact of a merge
> [Introduced][ce-10408] in GitLab 9.1.
After a merge request has been approved, a sparkline will appear on the merge request page displaying the average memory usage of the application. The sparkline includes thirty minutes of data prior to the merge, a dot to indicate the merge itself, and then will begin capturing thirty minutes of data after the merge.
This sparkline serves as a quick indicator of the impact on memory consumption of the recently merged changes. If there is a problem, action can then be taken to troubleshoot or revert the merge.
## Troubleshooting
## Troubleshooting
If the "Attempting to load performance data" screen continues to appear, it could be due to:
If the "Attempting to load performance data" screen continues to appear, it could be due to:
...
@@ -189,4 +197,5 @@ If the "Attempting to load performance data" screen continues to appear, it coul
...
@@ -189,4 +197,5 @@ If the "Attempting to load performance data" screen continues to appear, it coul
@@ -49,7 +49,7 @@ feature 'Resolving all open discussions in a merge request from an issue', featu
...
@@ -49,7 +49,7 @@ feature 'Resolving all open discussions in a merge request from an issue', featu
end
end
it'does not show a link to create a new issue'do
it'does not show a link to create a new issue'do
expect(page).not_tohave_link'open an issue to resolve them later'
expect(page).not_tohave_link'Create an issue to resolve them later'
end
end
end
end
...
@@ -59,18 +59,18 @@ feature 'Resolving all open discussions in a merge request from an issue', featu
...
@@ -59,18 +59,18 @@ feature 'Resolving all open discussions in a merge request from an issue', featu
end
end
it'shows a warning that the merge request contains unresolved discussions'do
it'shows a warning that the merge request contains unresolved discussions'do
expect(page).tohave_content'This merge request has unresolved discussions'
expect(page).tohave_content'There are unresolved discussions.'
end
end
it'has a link to resolve all discussions by creating an issue'do
it'has a link to resolve all discussions by creating an issue'do
page.within'.mr-widget-body'do
page.within'.mr-widget-body'do
expect(page).tohave_link'open an issue to resolve them later',href: new_namespace_project_issue_path(project.namespace,project,merge_request_to_resolve_discussions_of: merge_request.iid)
expect(page).tohave_link'Create an issue to resolve them later',href: new_namespace_project_issue_path(project.namespace,project,merge_request_to_resolve_discussions_of: merge_request.iid)
end
end
end
end
context'creating an issue for discussions'do
context'creating an issue for discussions'do
beforedo
beforedo
page.click_link'open an issue to resolve them later',href: new_namespace_project_issue_path(project.namespace,project,merge_request_to_resolve_discussions_of: merge_request.iid)
page.click_link'Create an issue to resolve them later',href: new_namespace_project_issue_path(project.namespace,project,merge_request_to_resolve_discussions_of: merge_request.iid)
end
end
it_behaves_like'creating an issue for a discussion'
it_behaves_like'creating an issue for a discussion'
let(:merge_request_title){"closes #{issue_1.to_reference}\n\n refers to #{issue_2.to_reference}"}
let(:merge_request_title){"closes #{issue_1.to_reference}\n\n refers to #{issue_2.to_reference}"}
it'does not display closing issue message'do
it'does not display closing issue message'do
expect(page).tohave_content("Accepting this merge request will close issue #{issue_1.to_reference}. Issue #{issue_2.to_reference} is mentioned but will not be closed.")
let(:merge_request_title){"closes #{issue_1.to_reference}\n\n refers to #{issue_2.to_reference}"}
let(:merge_request_title){"closes #{issue_1.to_reference}\n\n refers to #{issue_2.to_reference}"}
it'does not display closing issue message'do
it'does not display closing issue message'do
expect(page).tohave_content("Accepting this merge request will close issue #{issue_1.to_reference}. Issue #{issue_2.to_reference} is mentioned but will not be closed.")
expect(page).tohave_content("Closes issue #{issue_1.to_reference}. Issue #{issue_2.to_reference} is mentioned but will not be closed.")
expect(page).tohave_content("Issue #{issue_2.to_reference} is mentioned but will not be closed.")
Lorem ipsum dolor sit amet, consectetur adipiscing elit. Etiam ac ornare ligula, ut tempus arcu. Etiam ultricies accumsan dolor vitae faucibus. Donec at elit lacus. Mauris orci ante, aliquam quis lorem eget, convallis faucibus arcu. Aenean at pulvinar lacus. Ut viverra quam massa, molestie ornare tortor dignissim a. Suspendisse tristique pellentesque tellus, id lacinia metus elementum id. Nam tristique, arcu rhoncus faucibus viverra, lacus ipsum sagittis ligula, vitae convallis odio lacus a nibh. Ut tincidunt est purus, ac vestibulum augue maximus in. Suspendisse vel erat et mi ultricies semper. Pellentesque volutpat pellentesque consequat.
Lorem ipsum dolor sit amet, consectetur adipiscing elit. Etiam ac ornare ligula, ut tempus arcu. Etiam ultricies accumsan dolor vitae faucibus. Donec at elit lacus. Mauris orci ante, aliquam quis lorem eget, convallis faucibus arcu. Aenean at pulvinar lacus. Ut viverra quam massa, molestie ornare tortor dignissim a. Suspendisse tristique pellentesque tellus, id lacinia metus elementum id. Nam tristique, arcu rhoncus faucibus viverra, lacus ipsum sagittis ligula, vitae convallis odio lacus a nibh. Ut tincidunt est purus, ac vestibulum augue maximus in. Suspendisse vel erat et mi ultricies semper. Pellentesque volutpat pellentesque consequat.