Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
087680d7
Commit
087680d7
authored
May 13, 2019
by
Grzegorz Bizon
Committed by
Filipa Lacerda
May 24, 2019
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix deployment entity tests
Fixes style lint errors
parent
536b0224
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
5 additions
and
3 deletions
+5
-3
app/assets/javascripts/jobs/components/job_app.vue
app/assets/javascripts/jobs/components/job_app.vue
+3
-1
spec/javascripts/jobs/mock_data.js
spec/javascripts/jobs/mock_data.js
+1
-1
spec/serializers/deployment_entity_spec.rb
spec/serializers/deployment_entity_spec.rb
+1
-1
No files found.
app/assets/javascripts/jobs/components/job_app.vue
View file @
087680d7
...
@@ -123,7 +123,9 @@ export default {
...
@@ -123,7 +123,9 @@ export default {
job
(
newVal
,
oldVal
)
{
job
(
newVal
,
oldVal
)
{
if
(
_
.
isEmpty
(
oldVal
)
&&
!
_
.
isEmpty
(
newVal
.
pipeline
))
{
if
(
_
.
isEmpty
(
oldVal
)
&&
!
_
.
isEmpty
(
newVal
.
pipeline
))
{
this
.
fetchJobsForStage
(
this
.
fetchJobsForStage
(
this
.
job
.
pipeline
.
details
.
stages
.
find
(
stage
=>
stage
&&
stage
.
name
===
this
.
selectedStage
),
this
.
job
.
pipeline
.
details
.
stages
.
find
(
stage
=>
stage
&&
stage
.
name
===
this
.
selectedStage
,
),
);
);
}
}
...
...
spec/javascripts/jobs/mock_data.js
View file @
087680d7
...
@@ -995,7 +995,7 @@ export default {
...
@@ -995,7 +995,7 @@ export default {
},
},
duration
:
6
,
duration
:
6
,
finished_at
:
'
2017-06-01T17:32:00.042Z
'
,
finished_at
:
'
2017-06-01T17:32:00.042Z
'
,
stages
:
stages
,
stages
,
},
},
ref
:
{
ref
:
{
name
:
'
abc
'
,
name
:
'
abc
'
,
...
...
spec/serializers/deployment_entity_spec.rb
View file @
087680d7
...
@@ -107,7 +107,7 @@ describe DeploymentEntity do
...
@@ -107,7 +107,7 @@ describe DeploymentEntity do
it
'only exposes deployable name and path'
do
it
'only exposes deployable name and path'
do
project_job_path
(
project
,
deployment
.
deployable
).
tap
do
|
path
|
project_job_path
(
project
,
deployment
.
deployable
).
tap
do
|
path
|
expect
(
subject
.
fetch
(
:deployable
))
expect
(
subject
.
fetch
(
:deployable
))
.
to
eq
(
'name'
=>
'test'
,
'build_path'
=>
path
)
.
to
eq
(
name:
'test'
,
build_path:
path
)
end
end
end
end
end
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment