Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
0b3e3692
Commit
0b3e3692
authored
Nov 20, 2017
by
Jacopo
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Disables autocomplete in filtered search
Sets `autocomplete=off` to issuable filtered serarch.
parent
a248bb76
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
11 additions
and
1 deletion
+11
-1
app/helpers/search_helper.rb
app/helpers/search_helper.rb
+2
-1
changelogs/unreleased/38877-disable-autocomplete-in-filtered-search.yml
...eleased/38877-disable-autocomplete-in-filtered-search.yml
+5
-0
spec/helpers/search_helper_spec.rb
spec/helpers/search_helper_spec.rb
+4
-0
No files found.
app/helpers/search_helper.rb
View file @
0b3e3692
...
...
@@ -140,7 +140,8 @@ module SearchHelper
placeholder:
'Search or filter results...'
,
data:
{
'username-params'
=>
@users
.
to_json
(
only:
[
:id
,
:username
])
}
},
autocomplete:
'off'
}
if
@project
.
present?
...
...
changelogs/unreleased/38877-disable-autocomplete-in-filtered-search.yml
0 → 100644
View file @
0b3e3692
---
title
:
Disables autocomplete in filtered searc
merge_request
:
15477
author
:
Jacopo Beschi @jacopo-beschi
type
:
added
spec/helpers/search_helper_spec.rb
View file @
0b3e3692
...
...
@@ -102,6 +102,10 @@ describe SearchHelper do
it
'includes project base-endpoint'
do
expect
(
search_filter_input_options
(
''
)[
:data
][
'base-endpoint'
]).
to
eq
(
project_path
(
@project
))
end
it
'includes autocomplete=off flag'
do
expect
(
search_filter_input_options
(
''
)[
:autocomplete
]).
to
eq
(
'off'
)
end
end
context
'group'
do
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment