Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
1c275a75
Commit
1c275a75
authored
Dec 23, 2016
by
Lin Jen-Shin
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Update description stating that ordering is important
Feedback from Grzegorz
parent
13d009ce
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
2 additions
and
2 deletions
+2
-2
spec/models/ci/pipeline_spec.rb
spec/models/ci/pipeline_spec.rb
+2
-2
No files found.
spec/models/ci/pipeline_spec.rb
View file @
1c275a75
...
@@ -424,7 +424,7 @@ describe Ci::Pipeline, models: true do
...
@@ -424,7 +424,7 @@ describe Ci::Pipeline, models: true do
context
'when no ref is specified'
do
context
'when no ref is specified'
do
let
(
:pipelines
)
{
described_class
.
latest
.
all
}
let
(
:pipelines
)
{
described_class
.
latest
.
all
}
it
'
returns the latest pipelines for the same ref and different sha
'
do
it
'
gives the latest pipelines for the same ref and different sha in reverse chronological order
'
do
expect
(
pipelines
.
map
(
&
:sha
)).
to
eq
(
%w[C B A]
)
expect
(
pipelines
.
map
(
&
:sha
)).
to
eq
(
%w[C B A]
)
expect
(
pipelines
.
map
(
&
:status
)).
to
eq
(
%w[skipped failed success]
)
expect
(
pipelines
.
map
(
&
:status
)).
to
eq
(
%w[skipped failed success]
)
end
end
...
@@ -433,7 +433,7 @@ describe Ci::Pipeline, models: true do
...
@@ -433,7 +433,7 @@ describe Ci::Pipeline, models: true do
context
'when ref is specified'
do
context
'when ref is specified'
do
let
(
:pipelines
)
{
described_class
.
latest
(
'ref'
).
all
}
let
(
:pipelines
)
{
described_class
.
latest
(
'ref'
).
all
}
it
'
returns the latest pipelines for ref and different sha
'
do
it
'
gives the latest pipelines for ref and different sha in reverse chronological order
'
do
expect
(
pipelines
.
map
(
&
:sha
)).
to
eq
(
%w[B A]
)
expect
(
pipelines
.
map
(
&
:sha
)).
to
eq
(
%w[B A]
)
expect
(
pipelines
.
map
(
&
:status
)).
to
eq
(
%w[failed success]
)
expect
(
pipelines
.
map
(
&
:status
)).
to
eq
(
%w[failed success]
)
end
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment