Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
1f9fb9e4
Commit
1f9fb9e4
authored
Jun 20, 2017
by
Luke "Jared" Bennett
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove PersonalSnippet case for reportable_note specs
parent
f50a8065
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
8 additions
and
40 deletions
+8
-40
spec/features/reportable_note/snippets_spec.rb
spec/features/reportable_note/snippets_spec.rb
+0
-12
spec/support/features/reportable_note_shared_examples.rb
spec/support/features/reportable_note_shared_examples.rb
+8
-28
No files found.
spec/features/reportable_note/snippets_spec.rb
View file @
1f9fb9e4
...
...
@@ -19,16 +19,4 @@ describe 'Reportable note on snippets', :feature, :js do
it_behaves_like
'reportable note'
end
describe
'on personal snippet'
do
let
(
:snippet
)
{
create
(
:personal_snippet
,
:public
,
author:
user
)
}
let!
(
:note
)
{
create
(
:note_on_personal_snippet
,
noteable:
snippet
)
}
let!
(
:owners_note
)
{
create
(
:note_on_personal_snippet
,
noteable:
snippet
,
author:
user
)
}
before
do
visit
snippet_path
(
snippet
)
end
it_behaves_like
'reportable note'
,
true
end
end
spec/support/features/reportable_note_shared_examples.rb
View file @
1f9fb9e4
require
'spec_helper'
shared_examples
'reportable note'
do
|
is_a_personal_snippet
|
shared_examples
'reportable note'
do
include
NotesHelper
let
(
:comment
)
{
find
(
"#
#{
ActionView
::
RecordIdentifier
.
dom_id
(
note
)
}
"
)
}
...
...
@@ -11,25 +11,6 @@ shared_examples 'reportable note' do |is_a_personal_snippet|
expect
(
comment
).
to
have_selector
(
more_actions_selector
)
end
if
is_a_personal_snippet
it
'dropdown has Report link on other users comment'
do
dropdown
=
comment
.
find
(
more_actions_selector
)
open_dropdown
(
dropdown
)
expect
(
dropdown
).
to
have_link
(
'Report as abuse'
,
href:
abuse_report_path
)
end
it
'dropdown has Edit and Delete links on the owners comment'
do
find
(
'#notes-list .note'
,
match: :first
)
other_comment
=
all
(
'#notes-list .note'
).
last
dropdown
=
other_comment
.
find
(
more_actions_selector
)
open_dropdown
(
dropdown
)
expect
(
dropdown
).
to
have_button
(
'Edit comment'
)
expect
(
dropdown
).
to
have_link
(
'Delete comment'
,
href:
note_url
(
owners_note
,
project
))
end
else
it
'dropdown has Edit, Report and Delete links'
do
dropdown
=
comment
.
find
(
more_actions_selector
)
open_dropdown
(
dropdown
)
...
...
@@ -38,7 +19,6 @@ shared_examples 'reportable note' do |is_a_personal_snippet|
expect
(
dropdown
).
to
have_link
(
'Report as abuse'
,
href:
abuse_report_path
)
expect
(
dropdown
).
to
have_link
(
'Delete comment'
,
href:
note_url
(
note
,
project
))
end
end
it
'Report button links to a report page'
do
dropdown
=
comment
.
find
(
more_actions_selector
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment