Extract helper methods to clean up RepositoryArchiveCleanUpService spec

spec/services/repository_archive_clean_up_service_spec.rb

@@ -18,93 +18,64 @@ describe RepositoryArchiveCleanUpService, services: true do
     end
 
     context 'when the downloads directory exists' do
-      context 'when archives older than 2 hours exists' do
-        it 'removes old files that matches valid archive extensions' do
-          Dir.mktmpdir do |path|
-            stub_repository_downloads_path(path)
-            dirname = File.join(path, 'sample.git')
-            files = create_temporary_files(dirname, %w[tar tar.bz2 tar.gz zip], 2.hours)
-
-            service.execute
-
-            files.each { |file| expect(File.exist?(file)).to eq false }
-            expect(File.directory?(dirname)).to eq false
-          end
-        end
-
-        it 'keeps old files that does not matches valid archive extensions' do
-          Dir.mktmpdir do |path|
-            stub_repository_downloads_path(path)
-            dirname = File.join(path, 'sample.git')
-            files = create_temporary_files(dirname, %w[conf rb], 2.hours)
-
+      shared_examples 'invalid archive files' do |dirname, extensions, mtime|
+        it 'does not remove files and directoy' do
+          in_directory_with_files(dirname, extensions, mtime) do |dir, files|
             service.execute
 
             files.each { |file| expect(File.exist?(file)).to eq true }
-            expect(File.directory?(dirname)).to eq true
+            expect(File.directory?(dir)).to eq true
+          end
         end
       end
 
-        it 'keeps old files inside invalid directories' do
-          Dir.mktmpdir do |path|
-            stub_repository_downloads_path(path)
-            dirname = File.join(path, 'john_doe/sample.git')
-            files = create_temporary_files(dirname, %w[conf rb tar tar.gz], 2.hours)
-
+      it 'removes files older than 2 hours that matches valid archive extensions' do
+        in_directory_with_files('sample.git', %w[tar tar.bz2 tar.gz zip], 2.hours) do |dir, files|
           service.execute
 
-            files.each { |file| expect(File.exist?(file)).to eq true }
-            expect(File.directory?(dirname)).to eq true
-          end
+          files.each { |file| expect(File.exist?(file)).to eq false }
+          expect(File.directory?(dir)).to eq false
         end
       end
 
-      context 'when archives older than 2 hours does not exist' do
-        it 'keeps files that matches valid archive extensions' do
-          Dir.mktmpdir do |path|
-            dirname = File.join(path, 'sample.git')
-            files = create_temporary_files(dirname, %w[tar tar.bz2 tar.gz zip], 1.hour)
-
-            service.execute
-
-            files.each { |file| expect(File.exist?(file)).to eq true }
-            expect(File.directory?(dirname)).to eq true
+      context 'with files older than 2 hours that does not matches valid archive extensions' do
+        it_behaves_like 'invalid archive files', 'sample.git', %w[conf rb], 2.hours
       end
+
+      context 'with files older than 2 hours inside invalid directories' do
+        it_behaves_like 'invalid archive files', 'john_doe/sample.git', %w[conf rb tar tar.gz], 2.hours
       end
 
-        it 'keeps files that does not matches valid archive extensions' do
-          Dir.mktmpdir do |path|
-            dirname = File.join(path, 'sample.git')
-            files = create_temporary_files(dirname, %w[conf rb], 1.hour)
+      context 'with files newer than 2 hours that matches valid archive extensions' do
+        it_behaves_like 'invalid archive files', 'sample.git', %w[tar tar.bz2 tar.gz zip], 1.hour
+      end
 
-            service.execute
+      context 'with files newer than 2 hours that does not matches valid archive extensions' do
+        it_behaves_like 'invalid archive files', 'sample.git', %w[conf rb], 1.hour
+      end
 
-            files.each { |file| expect(File.exist?(file)).to eq true }
-            expect(File.directory?(dirname)).to eq true
+      context 'with files newer than 2 hours inside invalid directories' do
+        it_behaves_like 'invalid archive files', 'sample.git', %w[conf rb tar tar.gz], 1.hour
       end
     end
 
-        it 'keeps files inside invalid directories' do
-          Dir.mktmpdir do |path|
-            dirname = File.join(path, 'john_doe/sample.git')
-            files = create_temporary_files(dirname, %w[conf rb tar tar.gz], 1.hour)
+    def in_directory_with_files(dirname, extensions, mtime)
+      Dir.mktmpdir do |tmpdir|
+        stub_repository_downloads_path(tmpdir)
+        dir = File.join(tmpdir, dirname)
+        files = create_temporary_files(dir, extensions, mtime)
 
-            service.execute
-
-            files.each { |file| expect(File.exist?(file)).to eq true }
-            expect(File.directory?(dirname)).to eq true
-          end
-        end
+        yield(dir, files)
       end
     end
 
-    def create_temporary_files(dirname, extensions, mtime)
-      FileUtils.mkdir_p(dirname)
-      FileUtils.touch(extensions.map { |ext| File.join(dirname, "sample.#{ext}") }, mtime: Time.now - mtime)
-    end
-
     def stub_repository_downloads_path(path)
       allow(Gitlab.config.gitlab).to receive(:repository_downloads_path).and_return(path)
     end
+
+    def create_temporary_files(dir, extensions, mtime)
+      FileUtils.mkdir_p(dir)
+      FileUtils.touch(extensions.map { |ext| File.join(dir, "sample.#{ext}") }, mtime: Time.now - mtime)
+    end
   end
 end