Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
2b78f223
Commit
2b78f223
authored
Jul 03, 2018
by
Rémy Coutable
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix link to job when creating a new issue from a failed job
Signed-off-by:
Rémy Coutable
<
remy@rymai.me
>
parent
48f4ccd3
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
7 additions
and
2 deletions
+7
-2
app/serializers/build_details_entity.rb
app/serializers/build_details_entity.rb
+1
-1
changelogs/unreleased/36907-fix-new-issue-link-from-failed-job.yml
...s/unreleased/36907-fix-new-issue-link-from-failed-job.yml
+5
-0
spec/features/projects/jobs_spec.rb
spec/features/projects/jobs_spec.rb
+1
-1
No files found.
app/serializers/build_details_entity.rb
View file @
2b78f223
...
@@ -35,7 +35,7 @@ class BuildDetailsEntity < JobEntity
...
@@ -35,7 +35,7 @@ class BuildDetailsEntity < JobEntity
def
build_failed_issue_options
def
build_failed_issue_options
{
title:
"Job Failed #
#{
build
.
id
}
"
,
{
title:
"Job Failed #
#{
build
.
id
}
"
,
description:
"Job [#
#{
build
.
id
}
](
#{
project_job_
path
(
project
,
build
)
}
) failed for
#{
build
.
sha
}
:
\n
"
}
description:
"Job [#
#{
build
.
id
}
](
#{
project_job_
url
(
project
,
build
)
}
) failed for
#{
build
.
sha
}
:
\n
"
}
end
end
def
current_user
def
current_user
...
...
changelogs/unreleased/36907-fix-new-issue-link-from-failed-job.yml
0 → 100644
View file @
2b78f223
---
title
:
Fix link to job when creating a new issue from a failed job
merge_request
:
20328
author
:
type
:
fixed
spec/features/projects/jobs_spec.rb
View file @
2b78f223
...
@@ -165,7 +165,7 @@ feature 'Jobs', :clean_gitlab_redis_shared_state do
...
@@ -165,7 +165,7 @@ feature 'Jobs', :clean_gitlab_redis_shared_state do
it
'links to issues/new with the title and description filled in'
do
it
'links to issues/new with the title and description filled in'
do
button_title
=
"Job Failed #
#{
job
.
id
}
"
button_title
=
"Job Failed #
#{
job
.
id
}
"
job_url
=
project_job_
path
(
project
,
job
)
job_url
=
project_job_
url
(
project
,
job
,
host:
page
.
server
.
host
,
port:
page
.
server
.
port
)
options
=
{
issue:
{
title:
button_title
,
description:
"Job [#
#{
job
.
id
}
](
#{
job_url
}
) failed for
#{
job
.
sha
}
:
\n
"
}
}
options
=
{
issue:
{
title:
button_title
,
description:
"Job [#
#{
job
.
id
}
](
#{
job_url
}
) failed for
#{
job
.
sha
}
:
\n
"
}
}
href
=
new_project_issue_path
(
project
,
options
)
href
=
new_project_issue_path
(
project
,
options
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment