Merge branch 'frozen-string-lib-gitlab-even-even-even-more' into 'master'

Enable even more frozen string for lib/gitlab

See merge request gitlab-org/gitlab-ce!23225

changelogs/unreleased/frozen-string-lib-gitlab-even-even-even-more.yml

+---
+title: Enable even more frozen string for lib/gitlab
+merge_request:
+author: gfyoung
+type: performance

lib/gitlab/ci/config/entry/retry.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Ci
     class Config

lib/gitlab/performance_bar/peek_query_tracker.rb

+# frozen_string_literal: true
+
 # Inspired by https://github.com/peek/peek-pg/blob/master/lib/peek/views/pg.rb
 # PEEK_DB_CLIENT is a constant set in config/initializers/peek.rb
 module Gitlab

lib/gitlab/popen/runner.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Popen
     class Runner

lib/gitlab/profiler/total_time_flat_printer.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Profiler
     class TotalTimeFlatPrinter < RubyProf::FlatPrinter

lib/gitlab/project_authorizations/with_nested_groups.rb

+# frozen_string_literal: true
+
 module Gitlab
   module ProjectAuthorizations
     # Calculating new project authorizations when supporting nested groups.

lib/gitlab/project_authorizations/without_nested_groups.rb

+# frozen_string_literal: true
+
 module Gitlab
   module ProjectAuthorizations
     # Calculating new project authorizations when not supporting nested groups.

lib/gitlab/prometheus/additional_metrics_parser.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Prometheus
     module AdditionalMetricsParser

lib/gitlab/prometheus/metric.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Prometheus
     class Metric

lib/gitlab/prometheus/metric_group.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Prometheus
     class MetricGroup

lib/gitlab/prometheus/parsing_error.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Prometheus
     ParsingError = Class.new(StandardError)

lib/gitlab/prometheus/queries/additional_metrics_deployment_query.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Prometheus
     module Queries

lib/gitlab/prometheus/queries/additional_metrics_environment_query.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Prometheus
     module Queries

lib/gitlab/prometheus/queries/base_query.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Prometheus
     module Queries

lib/gitlab/prometheus/queries/deployment_query.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Prometheus
     module Queries

lib/gitlab/prometheus/queries/environment_query.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Prometheus
     module Queries

lib/gitlab/prometheus/queries/matched_metric_query.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Prometheus
     module Queries

lib/gitlab/prometheus/queries/query_additional_metrics.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Prometheus
     module Queries

lib/gitlab/query_limiting/active_support_subscriber.rb

+# frozen_string_literal: true
+
 module Gitlab
   module QueryLimiting
     class ActiveSupportSubscriber < ActiveSupport::Subscriber

lib/gitlab/query_limiting/transaction.rb

+# frozen_string_literal: true
+
 module Gitlab
   module QueryLimiting
     class Transaction
@@ -68,7 +70,7 @@ module Gitlab
 
       def error_message
         header = 'Too many SQL queries were executed'
-        header += " in #{action}" if action
+        header = "#{header} in #{action}" if action
 
         "#{header}: a maximum of #{THRESHOLD} is allowed but #{count} SQL queries were executed"
       end

lib/gitlab/quick_actions/command_definition.rb

+# frozen_string_literal: true
+
 module Gitlab
   module QuickActions
     class CommandDefinition

lib/gitlab/quick_actions/dsl.rb

+# frozen_string_literal: true
+
 module Gitlab
   module QuickActions
     module Dsl

lib/gitlab/quick_actions/extractor.rb

+# frozen_string_literal: true
+
 module Gitlab
   module QuickActions
     # This class takes an array of commands that should be extracted from a

lib/gitlab/quick_actions/spend_time_and_date_separator.rb

+# frozen_string_literal: true
+
 module Gitlab
   module QuickActions
     # This class takes spend command argument

lib/gitlab/quick_actions/substitution_definition.rb

+# frozen_string_literal: true
+
 module Gitlab
   module QuickActions
     class SubstitutionDefinition < CommandDefinition

lib/gitlab/redis/cache.rb

+# frozen_string_literal: true
+
 # please require all dependencies below:
 require_relative 'wrapper' unless defined?(::Rails) && ::Rails.root.present?
 

lib/gitlab/redis/queues.rb

+# frozen_string_literal: true
+
 # please require all dependencies below:
 require_relative 'wrapper' unless defined?(::Gitlab::Redis::Wrapper)
 

lib/gitlab/redis/shared_state.rb

+# frozen_string_literal: true
+
 # please require all dependencies below:
 require_relative 'wrapper' unless defined?(::Gitlab::Redis::Wrapper)
 

lib/gitlab/redis/wrapper.rb

+# frozen_string_literal: true
+
 # This file should only be used by sub-classes, not directly by any clients of the sub-classes
 # please require all dependencies below:
 require 'active_support/core_ext/hash/keys'

lib/gitlab/request_profiler/middleware.rb

+# frozen_string_literal: true
+
 require 'ruby-prof'
 
 module Gitlab

lib/gitlab/request_profiler/profile.rb

+# frozen_string_literal: true
+
 module Gitlab
   module RequestProfiler
     class Profile

lib/gitlab/sanitizers/svg.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Sanitizers
     module SVG

lib/gitlab/sanitizers/svg/whitelist.rb

+# frozen_string_literal: true
+
 # Generated from:
 # SVG element list: https://www.w3.org/TR/SVG/eltindex.html
 # SVG Attribute list: https://www.w3.org/TR/SVG/attindex.html

lib/gitlab/search/parsed_query.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Search
     class ParsedQuery

lib/gitlab/search/query.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Search
     class Query < SimpleDelegator

lib/gitlab/serializer/ci/variables.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Serializer
     module Ci

lib/gitlab/serializer/pagination.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Serializer
     class Pagination

lib/gitlab/sherlock/collection.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Sherlock
     # A collection of transactions recorded by Sherlock.

lib/gitlab/sherlock/file_sample.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Sherlock
     class FileSample

lib/gitlab/sherlock/line_profiler.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Sherlock
     # Class for profiling code on a per line basis.

lib/gitlab/sherlock/line_sample.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Sherlock
     class LineSample

lib/gitlab/sherlock/location.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Sherlock
     class Location

lib/gitlab/sherlock/middleware.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Sherlock
     # Rack middleware used for tracking request metrics.

lib/gitlab/sherlock/query.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Sherlock
     class Query
@@ -48,7 +50,7 @@ module Gitlab
         end
 
         unless @query.end_with?(';')
-          @query += ';'
+          @query = "#{@query};"
         end
       end
 

lib/gitlab/sherlock/transaction.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Sherlock
     class Transaction

lib/gitlab/sidekiq_logging/json_formatter.rb

+# frozen_string_literal: true
+
 module Gitlab
   module SidekiqLogging
     class JSONFormatter

lib/gitlab/sidekiq_logging/structured_logger.rb

+# frozen_string_literal: true
+
 module Gitlab
   module SidekiqLogging
     class StructuredLogger

lib/gitlab/sidekiq_middleware/arguments_logger.rb

+# frozen_string_literal: true
+
 module Gitlab
   module SidekiqMiddleware
     class ArgumentsLogger

lib/gitlab/sidekiq_middleware/request_store_middleware.rb

+# frozen_string_literal: true
+
 module Gitlab
   module SidekiqMiddleware
     class RequestStoreMiddleware

lib/gitlab/sidekiq_middleware/shutdown.rb

+# frozen_string_literal: true
+
 require 'mutex_m'
 
 module Gitlab

lib/gitlab/sidekiq_status/client_middleware.rb

+# frozen_string_literal: true
+
 module Gitlab
   module SidekiqStatus
     class ClientMiddleware

lib/gitlab/sidekiq_status/server_middleware.rb

+# frozen_string_literal: true
+
 module Gitlab
   module SidekiqStatus
     class ServerMiddleware

lib/gitlab/sidekiq_versioning/manager.rb

+# frozen_string_literal: true
+
 module Gitlab
   module SidekiqVersioning
     module Manager

lib/gitlab/slash_commands/base_command.rb

+# frozen_string_literal: true
+
 module Gitlab
   module SlashCommands
     class BaseCommand

lib/gitlab/slash_commands/command.rb

+# frozen_string_literal: true
+
 module Gitlab
   module SlashCommands
     class Command < BaseCommand

lib/gitlab/slash_commands/deploy.rb

+# frozen_string_literal: true
+
 module Gitlab
   module SlashCommands
     class Deploy < BaseCommand

lib/gitlab/slash_commands/help.rb

+# frozen_string_literal: true
+
 module Gitlab
   module SlashCommands
     class Help < BaseCommand

lib/gitlab/slash_commands/issue_command.rb

+# frozen_string_literal: true
+
 module Gitlab
   module SlashCommands
     class IssueCommand < BaseCommand

lib/gitlab/slash_commands/issue_move.rb

+# frozen_string_literal: true
+
 module Gitlab
   module SlashCommands
     class IssueMove < IssueCommand

lib/gitlab/slash_commands/issue_new.rb

+# frozen_string_literal: true
+
 module Gitlab
   module SlashCommands
     class IssueNew < IssueCommand

lib/gitlab/slash_commands/issue_search.rb

+# frozen_string_literal: true
+
 module Gitlab
   module SlashCommands
     class IssueSearch < IssueCommand

lib/gitlab/slash_commands/issue_show.rb

+# frozen_string_literal: true
+
 module Gitlab
   module SlashCommands
     class IssueShow < IssueCommand

lib/gitlab/slash_commands/presenters/access.rb

+# frozen_string_literal: true
+
 module Gitlab
   module SlashCommands
     module Presenters

lib/gitlab/slash_commands/presenters/base.rb

+# frozen_string_literal: true
+
 module Gitlab
   module SlashCommands
     module Presenters

lib/gitlab/slash_commands/presenters/deploy.rb

+# frozen_string_literal: true
+
 module Gitlab
   module SlashCommands
     module Presenters

lib/gitlab/slash_commands/presenters/help.rb

+# frozen_string_literal: true
+
 module Gitlab
   module SlashCommands
     module Presenters

lib/gitlab/slash_commands/presenters/issue_base.rb

+# frozen_string_literal: true
+
 module Gitlab
   module SlashCommands
     module Presenters

lib/gitlab/slash_commands/presenters/issue_move.rb

 # coding: utf-8
+# frozen_string_literal: true
+
 module Gitlab
   module SlashCommands
     module Presenters

lib/gitlab/slash_commands/presenters/issue_new.rb

+# frozen_string_literal: true
+
 module Gitlab
   module SlashCommands
     module Presenters

lib/gitlab/slash_commands/presenters/issue_search.rb

+# frozen_string_literal: true
+
 module Gitlab
   module SlashCommands
     module Presenters

lib/gitlab/slash_commands/presenters/issue_show.rb

+# frozen_string_literal: true
+
 module Gitlab
   module SlashCommands
     module Presenters
@@ -38,10 +40,10 @@ module Gitlab
         end
 
         def text
-          message = "**#{status_text(@resource)}**"
+          message = ["**#{status_text(@resource)}**"]
 
           if @resource.upvotes.zero? && @resource.downvotes.zero? && @resource.user_notes_count.zero?
-            return message
+            return message.join
           end
 
           message << " · "
@@ -49,7 +51,7 @@ module Gitlab
           message << ":-1: #{@resource.downvotes} " unless @resource.downvotes.zero?
           message << ":speech_balloon: #{@resource.user_notes_count}" unless @resource.user_notes_count.zero?
 
-          message
+          message.join
         end
 
         def pretext

lib/gitlab/slash_commands/result.rb

-module Gitlab # rubocop:disable Naming/FileName
+# rubocop:disable Naming/FileName
+# frozen_string_literal: true
+
+module Gitlab
   module SlashCommands
     Result = Struct.new(:type, :message)
   end

lib/gitlab/sql/cte.rb

+# frozen_string_literal: true
+
 module Gitlab
   module SQL
     # Class for easily building CTE statements.

lib/gitlab/sql/glob.rb

+# frozen_string_literal: true
+
 module Gitlab
   module SQL
     module Glob

lib/gitlab/sql/pattern.rb

+# frozen_string_literal: true
+
 module Gitlab
   module SQL
     module Pattern

lib/gitlab/sql/recursive_cte.rb

+# frozen_string_literal: true
+
 module Gitlab
   module SQL
     # Class for easily building recursive CTE statements.

lib/gitlab/sql/union.rb

+# frozen_string_literal: true
+
 module Gitlab
   module SQL
     # Class for building SQL UNION statements.

lib/gitlab/template/base_template.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Template
     class BaseTemplate

lib/gitlab/template/dockerfile_template.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Template
     class DockerfileTemplate < BaseTemplate

lib/gitlab/template/finders/base_template_finder.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Template
     module Finders

lib/gitlab/template/finders/global_template_finder.rb

+# frozen_string_literal: true
+
 # Searches and reads file present on GitLab installation directory
 module Gitlab
   module Template
@@ -21,7 +23,7 @@ module Gitlab
         end
 
         def list_files_for(dir)
-          dir << '/' unless dir.end_with?('/')
+          dir = "#{dir}/" unless dir.end_with?('/')
           Dir.glob(File.join(dir, "*#{@extension}")).select { |f| f =~ self.class.filter_regex(@extension) }
         end
 

lib/gitlab/template/finders/repo_template_finder.rb

+# frozen_string_literal: true
+
 # Searches and reads files present on each GitLab project repository
 module Gitlab
   module Template
@@ -33,7 +35,7 @@ module Gitlab
         def list_files_for(dir)
           return [] unless @commit
 
-          dir << '/' unless dir.end_with?('/')
+          dir = "#{dir}/" unless dir.end_with?('/')
 
           entries = @repository.tree(:head, dir).entries
 

lib/gitlab/template/gitignore_template.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Template
     class GitignoreTemplate < BaseTemplate

lib/gitlab/template/gitlab_ci_yml_template.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Template
     class GitlabCiYmlTemplate < BaseTemplate

lib/gitlab/template/issue_template.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Template
     class IssueTemplate < BaseTemplate

lib/gitlab/template/merge_request_template.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Template
     class MergeRequestTemplate < BaseTemplate

lib/gitlab/testing/request_blocker_middleware.rb

+# frozen_string_literal: true
+
 # rubocop:disable Style/ClassVars
 
 # This is inspired by http://www.salsify.com/blog/engineering/tearing-capybara-ajax-tests

lib/gitlab/testing/request_inspector_middleware.rb

+# frozen_string_literal: true
+
 # rubocop:disable Style/ClassVars
 
 module Gitlab
@@ -35,7 +37,7 @@ module Gitlab
         request_headers = env_http_headers(env)
         status, headers, body = @app.call(env)
 
-        full_body = ''
+        full_body = +''
         body.each { |b| full_body << b }
 
         request = OpenStruct.new(

lib/gitlab/utils/merge_hash.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Utils
     module MergeHash

lib/gitlab/utils/override.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Utils
     module Override

lib/gitlab/utils/strong_memoize.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Utils
     module StrongMemoize

lib/gitlab/verify/batch_verifier.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Verify
     class BatchVerifier

lib/gitlab/verify/job_artifacts.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Verify
     class JobArtifacts < BatchVerifier

lib/gitlab/verify/lfs_objects.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Verify
     class LfsObjects < BatchVerifier

lib/gitlab/verify/rake_task.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Verify
     class RakeTask

lib/gitlab/verify/uploads.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Verify
     class Uploads < BatchVerifier

lib/gitlab/view/presenter/base.rb

+# frozen_string_literal: true
+
 module Gitlab
   module View
     module Presenter

lib/gitlab/view/presenter/delegated.rb

+# frozen_string_literal: true
+
 module Gitlab
   module View
     module Presenter

lib/gitlab/view/presenter/factory.rb

+# frozen_string_literal: true
+
 module Gitlab
   module View
     module Presenter

lib/gitlab/view/presenter/simple.rb

+# frozen_string_literal: true
+
 module Gitlab
   module View
     module Presenter

lib/gitlab/webpack/dev_server_middleware.rb

+# frozen_string_literal: true
+
 # This Rack middleware is intended to proxy the webpack assets directory to the
 # webpack-dev-server.  It is only intended for use in development.
 

lib/gitlab/webpack/manifest.rb

+# frozen_string_literal: true
+
 require 'webpack/rails/manifest'
 
 module Gitlab