Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
3262378e
Commit
3262378e
authored
Nov 22, 2017
by
Rémy Coutable
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
In EeCompatCheck, always reset to canonical-ee/master when applying a patch
Signed-off-by:
Rémy Coutable
<
remy@rymai.me
>
parent
f5ab0f52
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
4 additions
and
4 deletions
+4
-4
lib/gitlab/ee_compat_check.rb
lib/gitlab/ee_compat_check.rb
+4
-4
No files found.
lib/gitlab/ee_compat_check.rb
View file @
3262378e
...
@@ -102,7 +102,7 @@ module Gitlab
...
@@ -102,7 +102,7 @@ module Gitlab
end
end
def
ce_branch_compat_check!
def
ce_branch_compat_check!
if
check_patch
(
ce_patch_full_path
,
remote:
'canonical-ce'
).
zero?
if
check_patch
(
ce_patch_full_path
).
zero?
puts
applies_cleanly_msg
(
ce_branch
)
puts
applies_cleanly_msg
(
ce_branch
)
throw
(
:halt_check
)
throw
(
:halt_check
)
end
end
...
@@ -129,7 +129,7 @@ module Gitlab
...
@@ -129,7 +129,7 @@ module Gitlab
end
end
def
ee_branch_compat_check!
def
ee_branch_compat_check!
unless
check_patch
(
ee_patch_full_path
,
remote:
'canonical-ee'
).
zero?
unless
check_patch
(
ee_patch_full_path
).
zero?
puts
puts
puts
ee_branch_doesnt_apply_cleanly_msg
puts
ee_branch_doesnt_apply_cleanly_msg
...
@@ -140,9 +140,9 @@ module Gitlab
...
@@ -140,9 +140,9 @@ module Gitlab
puts
applies_cleanly_msg
(
ee_branch_found
)
puts
applies_cleanly_msg
(
ee_branch_found
)
end
end
def
check_patch
(
patch_path
,
remote
:
)
def
check_patch
(
patch_path
)
step
(
"Checking out master"
,
%w[git checkout master]
)
step
(
"Checking out master"
,
%w[git checkout master]
)
step
(
"Resetting to latest master"
,
%
W[git reset --hard
#{
remote
}
/master]
)
step
(
"Resetting to latest master"
,
%
w[git reset --hard canonical-ee
/master]
)
step
(
step
(
"Checking if
#{
patch_path
}
applies cleanly to EE/master"
,
"Checking if
#{
patch_path
}
applies cleanly to EE/master"
,
# Don't use --check here because it can result in a 0-exit status even
# Don't use --check here because it can result in a 0-exit status even
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment