Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
37213cc3
Commit
37213cc3
authored
Sep 20, 2017
by
Tim Zallmann
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Removed User Callout for Customer Experience
parent
8612b088
Changes
4
Show whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
0 additions
and
73 deletions
+0
-73
app/views/dashboard/projects/index.html.haml
app/views/dashboard/projects/index.html.haml
+0
-3
app/views/shared/_user_callout.html.haml
app/views/shared/_user_callout.html.haml
+0
-13
app/views/users/show.html.haml
app/views/users/show.html.haml
+0
-2
spec/features/user_callout_spec.rb
spec/features/user_callout_spec.rb
+0
-55
No files found.
app/views/dashboard/projects/index.html.haml
View file @
37213cc3
...
...
@@ -10,9 +10,6 @@
=
render
"projects/last_push"
%div
{
class:
container_class
}
-
if
show_callout?
(
'user_callout_dismissed'
)
=
render
'shared/user_callout'
-
if
has_projects_or_name?
(
@projects
,
params
)
=
render
'dashboard/projects_head'
=
render
'projects'
...
...
app/views/shared/_user_callout.html.haml
deleted
100644 → 0
View file @
8612b088
.user-callout
{
data:
{
uid:
'user_callout_dismissed'
}
}
.bordered-box.landing.content-block
%button
.btn.btn-default.close.js-close-callout
{
type:
'button'
,
'aria-label'
=>
'Dismiss customize experience box'
}
=
icon
(
'times'
,
class:
'dismiss-icon'
,
'aria-hidden'
=>
'true'
)
.svg-container
=
custom_icon
(
'icon_customization'
)
.user-callout-copy
%h4
Customize your experience
%p
Change syntax themes, default project pages, and more in preferences.
=
link_to
'Check it out'
,
profile_preferences_path
,
class:
'btn btn-primary js-close-callout'
app/views/users/show.html.haml
View file @
37213cc3
...
...
@@ -99,8 +99,6 @@
Snippets
%div
{
class:
container_class
}
-
if
@user
==
current_user
&&
show_callout?
(
'user_callout_dismissed'
)
=
render
'shared/user_callout'
.tab-content
#activity
.tab-pane
.row-content-block.calender-block.white.second-block.hidden-xs
...
...
spec/features/user_callout_spec.rb
deleted
100644 → 0
View file @
8612b088
require
'spec_helper'
describe
'User Callouts'
,
js:
true
do
let
(
:user
)
{
create
(
:user
)
}
let
(
:another_user
)
{
create
(
:user
)
}
let
(
:project
)
{
create
(
:project
,
path:
'gitlab'
,
name:
'sample'
)
}
before
do
sign_in
(
user
)
project
.
team
<<
[
user
,
:master
]
end
it
'takes you to the profile preferences when the link is clicked'
do
visit
dashboard_projects_path
click_link
'Check it out'
expect
(
current_path
).
to
eq
profile_preferences_path
end
it
'does not show when cookie is set'
do
visit
dashboard_projects_path
within
(
'.user-callout'
)
do
find
(
'.close'
).
trigger
(
'click'
)
end
visit
dashboard_projects_path
expect
(
page
).
not_to
have_selector
(
'.user-callout'
)
end
describe
'user callout should appear in two routes'
do
it
'shows up on the user profile'
do
visit
user_path
(
user
)
expect
(
find
(
'.user-callout'
)).
to
have_content
'Customize your experience'
end
it
'shows up on the dashboard projects'
do
visit
dashboard_projects_path
expect
(
find
(
'.user-callout'
)).
to
have_content
'Customize your experience'
end
end
it
'hides the user callout when click on the dismiss icon'
do
visit
user_path
(
user
)
within
(
'.user-callout'
)
do
find
(
'.close'
).
click
end
expect
(
page
).
not_to
have_selector
(
'.user-callout'
)
end
it
'does not show callout on another users profile'
do
visit
user_path
(
another_user
)
expect
(
page
).
not_to
have_selector
(
'.user-callout'
)
end
end
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment