Add lock for delete

lib/gitlab/ci/trace.rb

@@ -110,7 +110,7 @@ module Gitlab
         raise ArchiveError, 'Job is not finished yet' unless job.complete?
 
         if ChunkedFile::LiveTrace.exist?(job.id)
-          ChunkedFile::LiveTrace.open(job.id, "wb") do |stream|
+          ChunkedFile::LiveTrace.open(job.id, 'a+b') do |stream|
             archive_stream!(stream)
             stream.delete
           end

lib/gitlab/ci/trace/chunked_file/chunked_io.rb

@@ -128,7 +128,11 @@ module Gitlab
           end
 
           def present?
-            true
+            chunk_store.chunks_count(job_id) > 0
+          end
+
+          def delete
+            chunk_store.delete_all
           end
 
           private

lib/gitlab/ci/trace/chunked_file/concerns/permissions.rb

@@ -21,6 +21,7 @@ module Gitlab
               # write_lock
               before_method :write, :check_lock!
               before_method :truncate, :check_lock!
+              before_method :delete, :check_lock!
             end
 
             def initialize(job_id, size, mode = 'rb')
@@ -43,7 +44,7 @@ module Gitlab
             end
 
             def check_lock!
-              raise PermissionError, 'Could not write without lock' unless write_lock_uuid
+              raise PermissionError, 'Could not modify the file without lock' unless write_lock_uuid
             end
 
             def can_read!

lib/gitlab/ci/trace/chunked_file/live_trace.rb

@@ -29,7 +29,7 @@ module Gitlab
           # Efficient process than iterating each
           def truncate(offset)
             if truncate == 0
-              self.delete_all(job_id)
+              delete
             elsif offset == size
               # no-op
             else
@@ -37,6 +37,10 @@ module Gitlab
             end
           end
 
+          def present?
+            self.exist?(job_id)
+          end
+
           def delete
             ChunkStores::Redis.delete_all(job_id)
             ChunkStores::Database.delete_all(job_id)