Dry up spec some more

…to stop copy pasting test cases.

spec/lib/gitlab/ldap/person_spec.rb

@@ -17,8 +17,7 @@ describe Gitlab::LDAP::Person do
     )
   end
 
-  describe '.normalize_uid_or_dn' do
-    context 'given a DN' do
+  shared_examples_for 'normalizes the DN' do
     # Regarding the telephoneNumber test:
     #
     # I am not sure whether a space after the telephoneNumber plus sign is valid,
@@ -48,12 +47,12 @@ describe Gitlab::LDAP::Person do
 
     with_them do
       it 'normalizes the DN' do
-          assert_generic_test(test_description, described_class.normalize_uid_or_dn(given), expected)
+        assert_generic_test(test_description, subject, expected)
       end
     end
   end
 
-    context 'given a UID' do
+  shared_examples_for 'normalizes the UID' do
     where(:test_description, :given, :expected) do
       'strips extraneous whitespace'                                        | ' John C. Smith   '                     | 'john c. smith'
       'strips extraneous whitespace without changing escaped characters'    | '  Sebasti\\c3\\a1n\\ C.\\20Smith\\   ' | 'sebasti\\c3\\a1n\\ c.\\20smith\\ '
@@ -73,72 +72,28 @@ describe Gitlab::LDAP::Person do
 
     with_them do
       it 'normalizes the UID' do
-          assert_generic_test(test_description, described_class.normalize_uid_or_dn(given), expected)
+        assert_generic_test(test_description, subject, expected)
       end
     end
   end
+
+  describe '.normalize_uid_or_dn' do
+    subject { described_class.normalize_uid_or_dn(given) }
+
+    it_behaves_like 'normalizes the DN'
+    it_behaves_like 'normalizes the UID'
   end
 
   describe '.normalize_uid' do
-    context 'given a UID' do
-      where(:test_description, :given, :expected) do
-        'strips extraneous whitespace'                                        | ' John C. Smith   '                     | 'john c. smith'
-        'strips extraneous whitespace without changing escaped characters'    | '  Sebasti\\c3\\a1n\\ C.\\20Smith\\   ' | 'sebasti\\c3\\a1n\\ c.\\20smith\\ '
-        'downcases the whole string'                                          | 'John Smith'                            | 'john smith'
-        'does not strip the escaped leading space in an attribute value'      | '   \\ John Smith '                     | '\\ john smith'
-        'does not strip the escaped trailing space in an attribute value'     | '    John Smith\\   '                   | 'john smith\\ '
-        'does not strip the escaped leading newline in an attribute value'    | '     \\\nJohn Smith  '                 | '\\\njohn smith'
-        'does not strip the escaped trailing newline in an attribute value'   | '    John Smith\\\n  '                  | 'john smith\\\n'
-        'does not strip the unescaped leading newline in an attribute value'  | '   \nJohn Smith '                      | '\njohn smith'
-        'does not strip the unescaped trailing newline in an attribute value' | '  John Smith\n   '                     | 'john smith\n'
-        'does not strip non whitespace'                                       | 'John Smith'                            | 'john smith'
-        'does not treat escaped equal signs as attribute delimiters'          | ' foo  \\=  bar'                        | 'foo  \\=  bar'
-        'does not treat escaped hex equal signs as attribute delimiters'      | ' foo  \\3D  bar'                       | 'foo  \\3d  bar'
-        'does not treat escaped commas as attribute delimiters'               | ' Smith\\, John C.'                     | 'smith\\, john c.'
-        'does not treat escaped hex commas as attribute delimiters'           | ' Smith\\2C John C.'                    | 'smith\\2c john c.'
-      end
+    subject { described_class.normalize_uid(given) }
 
-      with_them do
-        it 'normalizes the UID' do
-          assert_generic_test(test_description, described_class.normalize_uid(given), expected)
-        end
-      end
-    end
+    it_behaves_like 'normalizes the UID'
   end
 
   describe '.normalize_dn' do
-    # Regarding the telephoneNumber test:
-    #
-    # I am not sure whether a space after the telephoneNumber plus sign is valid,
-    # and I am not sure if this is "proper" behavior under these conditions, and
-    # I am not sure if it matters to us or anyone else, so rather than dig
-    # through RFCs, I am only documenting the behavior here.
-    where(:test_description, :given, :expected) do
-      'strips extraneous whitespace'                                                               | 'uid     =John Smith ,  ou = People, dc=  example,dc =com'                                            | 'uid=john smith,ou=people,dc=example,dc=com'
-      'strips extraneous whitespace for a DN with a single RDN'                                    | 'uid  =  John Smith'                                                                                  | 'uid=john smith'
-      'strips extraneous whitespace without changing escaped characters'                           | 'uid   =  Sebasti\\c3\\a1n\\ C.\\20Smith\\   ,   ou=People (aka. \\22humans\\")  ,dc=example, dc=com' | 'uid=sebasti\\c3\\a1n\\ c.\\20smith\\ ,ou=people (aka. \\22humans\\"),dc=example,dc=com'
-      'strips extraneous whitespace without modifying the multivalued RDN'                         | 'uid = John Smith  + telephoneNumber  = +1 555-555-5555 , ou = People,dc=example,dc=com'              | 'uid=john smith+telephonenumber=+1 555-555-5555,ou=people,dc=example,dc=com'
-      'strips the space after the plus sign in the telephoneNumber'                                | 'uid = John Smith  + telephoneNumber  = + 1 555-555-5555 , ou = People,dc=example,dc=com'             | 'uid=john smith+telephonenumber=+1 555-555-5555,ou=people,dc=example,dc=com'
-      'downcases the whole string'                                                                 | 'UID=John Smith,ou=People,dc=example,dc=com'                                                          | 'uid=john smith,ou=people,dc=example,dc=com'
-      'for a null DN (empty string), returns empty string and does not error'                      | ''                                                                                                    | ''
-      'does not strip the escaped leading space in an attribute value (and does not error like Net::LDAP::DN.new does)' | 'uid=\\ John Smith,ou=People,dc=example,dc=com'                                  | 'uid=\\ john smith,ou=people,dc=example,dc=com'
-      'does not strip the escaped trailing space in an attribute value'                            | 'uid=John Smith\\ ,ou=People,dc=example,dc=com'                                                       | 'uid=john smith\\ ,ou=people,dc=example,dc=com'
-      'does not strip the escaped leading newline in an attribute value'                           | 'uid=\\\nJohn Smith,ou=People,dc=example,dc=com'                                                      | 'uid=\\\njohn smith,ou=people,dc=example,dc=com'
-      'does not strip the escaped trailing newline in an attribute value'                          | 'uid=John Smith\\\n,ou=People,dc=example,dc=com'                                                      | 'uid=john smith\\\n,ou=people,dc=example,dc=com'
-      'does not strip the unescaped leading newline in an attribute value'                         | 'uid=\nJohn Smith,ou=People,dc=example,dc=com'                                                        | 'uid=\njohn smith,ou=people,dc=example,dc=com'
-      'does not strip the unescaped trailing newline in an attribute value'                        | 'uid=John Smith\n ,ou=People,dc=example,dc=com'                                                       | 'uid=john smith\n,ou=people,dc=example,dc=com'
-      'does not strip non whitespace'                                                              | 'uid=John Smith,ou=People,dc=example,dc=com'                                                          | 'uid=john smith,ou=people,dc=example,dc=com'
-      'does not treat escaped equal signs as attribute delimiters'                                 | 'uid= foo  \\=  bar'                                                                                  | 'uid=foo  \\=  bar'
-      'does not treat escaped hex equal signs as attribute delimiters'                             | 'uid= foo  \\3D  bar'                                                                                 | 'uid=foo  \\3d  bar'
-      'does not treat escaped commas as attribute delimiters'                                      | 'uid= John C. Smith, ou=San Francisco\\, CA'                                                          | 'uid=john c. smith,ou=san francisco\\, ca'
-      'does not treat escaped hex commas as attribute delimiters'                                  | 'uid= John C. Smith, ou=San Francisco\\2C CA'                                                         | 'uid=john c. smith,ou=san francisco\\2c ca'
-    end
+    subject { described_class.normalize_dn(given) }
 
-    with_them do
-      it 'normalizes the DN' do
-        assert_generic_test(test_description, described_class.normalize_dn(given), expected)
-      end
-    end
+    it_behaves_like 'normalizes the DN'
   end
 
   describe '.is_dn?' do