Refactor `add_recipients`

58dd4a09 · blackst0ne · b8c098ec · 58dd4a09
Commit 58dd4a09 authored Apr 09, 2018 by blackst0ne
Show whitespace changes
Inline Side-by-side

Showing with 2 additions and 3 deletions

app/services/notification_recipient_service.rb app/services/notification_recipient_service.rb +2 -3

No files found.
--- a/app/services/notification_recipient_service.rb
+++ b/app/services/notification_recipient_service.rb
@@ -51,11 +51,10 @@ module NotificationRecipientService
      def add_recipients(users, type, reason)
        if users.is_a?(ActiveRecord::Relation)
-          users = users.includes(:notification_settings).to_a
+          users = users.includes(:notification_settings)
        end
-        users = Array(users)
+        users = Array(users).compact
-        users.compact!
        recipients.concat(users.map { |u| make_recipient(u, type, reason) })
      end