Encode Page-Title header as ISO-8859-1

5adae3d8 · Douwe Maan · e4412799 · 5adae3d8
Commit 5adae3d8 authored Sep 26, 2017 by Douwe Maan
Show whitespace changes
Inline Side-by-side

Showing with 2 additions and 1 deletion

app/controllers/application_controller.rb app/controllers/application_controller.rb +2 -1

No files found.
--- a/app/controllers/application_controller.rb
+++ b/app/controllers/application_controller.rb
@@ -339,6 +339,7 @@ class ApplicationController < ActionController::Base
  end

  def set_page_title_header
-    response.headers['Page-Title'] = page_title('GitLab')
+    # Per https://tools.ietf.org/html/rfc5987, headers need to be ISO-8859-1, not UTF-8
+    response.headers['Page-Title'] = page_title('GitLab').encode('ISO-8859-1')
  end
 end