Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
5e93320e
Commit
5e93320e
authored
Oct 20, 2017
by
Clement Ho
Committed by
Winnie Hellmann
Oct 21, 2017
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Use title as placeholder instead of issue title for reusability
parent
6b6fac9e
Changes
4
Show whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
12 additions
and
7 deletions
+12
-7
app/assets/javascripts/issue_show/components/fields/title.vue
...assets/javascripts/issue_show/components/fields/title.vue
+4
-4
changelogs/unreleased/use-title.yml
changelogs/unreleased/use-title.yml
+5
-0
spec/features/issues/issue_detail_spec.rb
spec/features/issues/issue_detail_spec.rb
+1
-1
spec/features/projects/issuable_templates_spec.rb
spec/features/projects/issuable_templates_spec.rb
+2
-2
No files found.
app/assets/javascripts/issue_show/components/fields/title.vue
View file @
5e93320e
...
@@ -16,15 +16,15 @@
...
@@ -16,15 +16,15 @@
<fieldset>
<fieldset>
<label
<label
class=
"sr-only"
class=
"sr-only"
for=
"issue-title"
>
for=
"issu
abl
e-title"
>
Title
Title
</label>
</label>
<input
<input
id=
"issue-title"
id=
"issu
abl
e-title"
class=
"form-control"
class=
"form-control"
type=
"text"
type=
"text"
placeholder=
"
Issue t
itle"
placeholder=
"
T
itle"
aria-label=
"
Issue t
itle"
aria-label=
"
T
itle"
v-model=
"formState.title"
v-model=
"formState.title"
@
keydown.meta.enter=
"updateIssuable"
@
keydown.meta.enter=
"updateIssuable"
@
keydown.ctrl.enter=
"updateIssuable"
/>
@
keydown.ctrl.enter=
"updateIssuable"
/>
...
...
changelogs/unreleased/use-title.yml
0 → 100644
View file @
5e93320e
---
title
:
Use title as placeholder instead of issue title for reusability
merge_request
:
author
:
type
:
other
spec/features/issues/issue_detail_spec.rb
View file @
5e93320e
...
@@ -25,7 +25,7 @@ feature 'Issue Detail', :js do
...
@@ -25,7 +25,7 @@ feature 'Issue Detail', :js do
wait_for_requests
wait_for_requests
click_link
'Edit'
click_link
'Edit'
fill_in
'issue-title'
,
with:
'issue title'
fill_in
'issu
abl
e-title'
,
with:
'issue title'
click_button
'Save'
click_button
'Save'
Users
::
DestroyService
.
new
(
user
).
execute
(
user
)
Users
::
DestroyService
.
new
(
user
).
execute
(
user
)
...
...
spec/features/projects/issuable_templates_spec.rb
View file @
5e93320e
...
@@ -35,7 +35,7 @@ feature 'issuable templates', :js do
...
@@ -35,7 +35,7 @@ feature 'issuable templates', :js do
page
.
within
(
'.content .issuable-actions'
)
do
page
.
within
(
'.content .issuable-actions'
)
do
click_on
'Edit'
click_on
'Edit'
end
end
fill_in
:'issue-title'
,
with:
'test issue title'
fill_in
:'issu
abl
e-title'
,
with:
'test issue title'
end
end
scenario
'user selects "bug" template'
do
scenario
'user selects "bug" template'
do
...
@@ -80,7 +80,7 @@ feature 'issuable templates', :js do
...
@@ -80,7 +80,7 @@ feature 'issuable templates', :js do
page
.
within
(
'.content .issuable-actions'
)
do
page
.
within
(
'.content .issuable-actions'
)
do
click_on
'Edit'
click_on
'Edit'
end
end
fill_in
:'issue-title'
,
with:
'test issue title'
fill_in
:'issu
abl
e-title'
,
with:
'test issue title'
fill_in
:'issue-description'
,
with:
prior_description
fill_in
:'issue-description'
,
with:
prior_description
end
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment