Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
62574be3
Commit
62574be3
authored
Apr 05, 2018
by
Felipe Artur
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix specs
parent
22423d28
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
6 additions
and
6 deletions
+6
-6
app/models/milestone.rb
app/models/milestone.rb
+2
-2
spec/features/labels_hierarchy_spec.rb
spec/features/labels_hierarchy_spec.rb
+2
-4
spec/javascripts/boards/issue_card_spec.js
spec/javascripts/boards/issue_card_spec.js
+2
-0
No files found.
app/models/milestone.rb
View file @
62574be3
...
...
@@ -34,8 +34,8 @@ class Milestone < ActiveRecord::Base
scope
:for_projects_and_groups
,
->
(
project_ids
,
group_ids
)
do
conditions
=
[]
conditions
<<
arel_table
[
:project_id
].
in
(
project_ids
)
if
project_ids
.
compact
.
any?
conditions
<<
arel_table
[
:group_id
].
in
(
group_ids
)
if
group_ids
.
compact
.
any?
conditions
<<
arel_table
[
:project_id
].
in
(
project_ids
)
if
project_ids
&
.
compact
&
.
any?
conditions
<<
arel_table
[
:group_id
].
in
(
group_ids
)
if
group_ids
&
.
compact
&
.
any?
where
(
conditions
.
reduce
(
:or
))
end
...
...
spec/features/labels_hierarchy_spec.rb
View file @
62574be3
...
...
@@ -115,9 +115,9 @@ feature 'Labels Hierarchy', :js, :nested_groups do
it
'filters by descendant group labels'
do
wait_for_requests
if
board
select_label_on_dropdown
(
group_label_3
.
title
)
if
board
expect
(
page
).
to
have_selector
(
'.card-title'
)
do
|
card
|
expect
(
card
).
not_to
have_selector
(
'a'
,
text:
labeled_issue_2
.
title
)
end
...
...
@@ -126,8 +126,6 @@ feature 'Labels Hierarchy', :js, :nested_groups do
expect
(
card
).
to
have_selector
(
'a'
,
text:
labeled_issue_3
.
title
)
end
else
select_label_on_dropdown
(
group_label_3
.
title
)
expect_issues_list_count
(
1
)
expect
(
page
).
to
have_selector
(
'span.issue-title-text'
,
text:
labeled_issue_3
.
title
)
end
...
...
spec/javascripts/boards/issue_card_spec.js
View file @
62574be3
...
...
@@ -41,6 +41,8 @@ describe('Issue card component', () => {
confidential
:
false
,
labels
:
[
list
.
label
],
assignees
:
[],
reference_path
:
'
#1
'
,
real_path
:
'
/test/1
'
});
component
=
new
Vue
({
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment