Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
6d9afdfb
Commit
6d9afdfb
authored
Mar 10, 2017
by
Annabel Dunstone Gray
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix alignment of resolve discussion button
parent
c4ba6ea6
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
17 additions
and
15 deletions
+17
-15
app/assets/stylesheets/pages/notes.scss
app/assets/stylesheets/pages/notes.scss
+4
-5
app/views/projects/notes/_note.html.haml
app/views/projects/notes/_note.html.haml
+9
-10
changelogs/unreleased/29189-discussion-button.yml
changelogs/unreleased/29189-discussion-button.yml
+4
-0
No files found.
app/assets/stylesheets/pages/notes.scss
View file @
6d9afdfb
...
@@ -384,7 +384,7 @@ ul.notes {
...
@@ -384,7 +384,7 @@ ul.notes {
top
:
0
;
top
:
0
;
.note-action-button
{
.note-action-button
{
margin-left
:
10
px
;
margin-left
:
8
px
;
}
}
}
}
...
@@ -400,8 +400,7 @@ ul.notes {
...
@@ -400,8 +400,7 @@ ul.notes {
}
}
.note-action-button
{
.note-action-button
{
display
:
inline-block
;
display
:
inline
;
margin-left
:
0
;
line-height
:
20px
;
line-height
:
20px
;
@media
(
min-width
:
$screen-sm-min
)
{
@media
(
min-width
:
$screen-sm-min
)
{
...
@@ -540,7 +539,6 @@ ul.notes {
...
@@ -540,7 +539,6 @@ ul.notes {
}
}
.line-resolve-btn
{
.line-resolve-btn
{
display
:
inline-block
;
position
:
relative
;
position
:
relative
;
top
:
2px
;
top
:
2px
;
padding
:
0
;
padding
:
0
;
...
@@ -563,8 +561,9 @@ ul.notes {
...
@@ -563,8 +561,9 @@ ul.notes {
}
}
svg
{
svg
{
position
:
relative
;
fill
:
$gray-darkest
;
fill
:
$gray-darkest
;
height
:
15px
;
width
:
15px
;
}
}
}
}
...
...
app/views/projects/notes/_note.html.haml
View file @
6d9afdfb
...
@@ -43,9 +43,7 @@
...
@@ -43,9 +43,7 @@
"inline-template"
=>
true
,
"inline-template"
=>
true
,
"ref"
=>
"note_#{note.id}"
}
"ref"
=>
"note_#{note.id}"
}
.note-action-button
%button
.note-action-button.line-resolve-btn
{
type:
"button"
,
=
icon
(
"spin spinner"
,
"v-show"
=>
"loading"
)
%button
.line-resolve-btn
{
type:
"button"
,
class:
(
"is-disabled"
unless
can_resolve
),
class:
(
"is-disabled"
unless
can_resolve
),
":class"
=>
"{ 'is-active': isResolved }"
,
":class"
=>
"{ 'is-active': isResolved }"
,
":aria-label"
=>
"buttonText"
,
":aria-label"
=>
"buttonText"
,
...
@@ -53,6 +51,7 @@
...
@@ -53,6 +51,7 @@
":title"
=>
"buttonText"
,
":title"
=>
"buttonText"
,
"v-show"
=>
"!loading"
,
"v-show"
=>
"!loading"
,
":ref"
=>
"'button'"
}
":ref"
=>
"'button'"
}
=
icon
(
"spin spinner"
,
"v-show"
=>
"loading"
)
=
render
"shared/icons/icon_status_success.svg"
=
render
"shared/icons/icon_status_success.svg"
...
...
changelogs/unreleased/29189-discussion-button.yml
0 → 100644
View file @
6d9afdfb
---
title
:
Fix alignment of resolve button
merge_request
:
author
:
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment