Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
6dd2a520
Commit
6dd2a520
authored
Dec 01, 2016
by
Mike Greiling
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
use e instead of event variable name
parent
54a794f2
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
10 additions
and
10 deletions
+10
-10
app/assets/javascripts/diff.js.es6
app/assets/javascripts/diff.js.es6
+5
-5
app/assets/javascripts/merge_request_tabs.js.es6
app/assets/javascripts/merge_request_tabs.js.es6
+5
-5
No files found.
app/assets/javascripts/diff.js.es6
View file @
6dd2a520
...
@@ -20,8 +20,8 @@
...
@@ -20,8 +20,8 @@
this.highlighSelectedLine();
this.highlighSelectedLine();
}
}
handleClickUnfold(e
vent
) {
handleClickUnfold(e) {
const $target = $(e
vent
.target);
const $target = $(e.target);
// current babel config relies on iterators implementation, so we cannot simply do:
// current babel config relies on iterators implementation, so we cannot simply do:
// const [oldLineNumber, newLineNumber] = this.lineNumbers($target.parent());
// const [oldLineNumber, newLineNumber] = this.lineNumbers($target.parent());
const ref = this.lineNumbers($target.parent());
const ref = this.lineNumbers($target.parent());
...
@@ -69,9 +69,9 @@
...
@@ -69,9 +69,9 @@
}
}
}
}
handleClickLineNum(e
vent
) {
handleClickLineNum(e) {
const hash = $(e
vent
.currentTarget).attr('href');
const hash = $(e.currentTarget).attr('href');
e
vent
.preventDefault();
e.preventDefault();
if (window.history.pushState) {
if (window.history.pushState) {
window.history.pushState(null, null, hash);
window.history.pushState(null, null, hash);
} else {
} else {
...
...
app/assets/javascripts/merge_request_tabs.js.es6
View file @
6dd2a520
...
@@ -91,13 +91,13 @@
...
@@ -91,13 +91,13 @@
.off('click', '.js-show-tab', this.showTab);
.off('click', '.js-show-tab', this.showTab);
}
}
showTab(e
vent
) {
showTab(e) {
e
vent
.preventDefault();
e.preventDefault();
this.activateTab($(e
vent
.target).data('action'));
this.activateTab($(e.target).data('action'));
}
}
tabShown(e
vent
) {
tabShown(e) {
const $target = $(e
vent
.target);
const $target = $(e.target);
const action = $target.data('action');
const action = $target.data('action');
if (action === 'commits') {
if (action === 'commits') {
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment