Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
8196794c
Commit
8196794c
authored
Apr 10, 2018
by
Grzegorz Bizon
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Add a test for job empty state with missing trace
parent
2ea25cbc
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
12 additions
and
1 deletion
+12
-1
lib/gitlab/ci/status/build/common.rb
lib/gitlab/ci/status/build/common.rb
+1
-1
spec/features/projects/jobs_spec.rb
spec/features/projects/jobs_spec.rb
+11
-0
No files found.
lib/gitlab/ci/status/build/common.rb
View file @
8196794c
...
@@ -7,7 +7,7 @@ module Gitlab
...
@@ -7,7 +7,7 @@ module Gitlab
{
{
image:
'illustrations/skipped-job_empty.svg'
,
image:
'illustrations/skipped-job_empty.svg'
,
size:
'svg-430'
,
size:
'svg-430'
,
title:
_
(
'This job does not have a trace.'
)
,
title:
_
(
'This job does not have a trace.'
)
}
}
end
end
...
...
spec/features/projects/jobs_spec.rb
View file @
8196794c
...
@@ -464,6 +464,17 @@ feature 'Jobs' do
...
@@ -464,6 +464,17 @@ feature 'Jobs' do
expect
(
page
).
to
have_content
(
'This job has been skipped'
)
expect
(
page
).
to
have_content
(
'This job has been skipped'
)
end
end
end
end
context
'when job is running but has no trace yet'
do
let
(
:job
)
{
create
(
:ci_build
,
:running
,
pipeline:
pipeline
)
}
it
'renders empty state'
do
visit
project_job_path
(
project
,
job
)
expect
(
job
).
not_to
have_trace
expect
(
page
).
to
have_content
(
'This job does not have a trace.'
)
end
end
end
end
describe
"POST /:project/jobs/:id/cancel"
,
:js
do
describe
"POST /:project/jobs/:id/cancel"
,
:js
do
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment