Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
8850da27
Commit
8850da27
authored
Jan 23, 2019
by
Grzegorz Bizon
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Extract common `when` code between CI/CD processables
parent
cd9409f0
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
1 addition
and
12 deletions
+1
-12
app/models/ci/bridge.rb
app/models/ci/bridge.rb
+0
-7
app/models/ci/build.rb
app/models/ci/build.rb
+0
-4
app/models/concerns/ci/processable.rb
app/models/concerns/ci/processable.rb
+1
-1
No files found.
app/models/ci/bridge.rb
View file @
8850da27
...
...
@@ -37,13 +37,6 @@ module Ci
false
end
##
# TODO we probably want to add support for `when` configuration.
#
def
when
'on_success'
end
def
expanded_environment_name
end
...
...
app/models/ci/build.rb
View file @
8850da27
...
...
@@ -639,10 +639,6 @@ module Ci
super
||
project
.
try
(
:build_coverage_regex
)
end
def
when
read_attribute
(
:when
)
||
'on_success'
end
def
options
read_metadata_attribute
(
:options
,
:config_options
,
{})
end
...
...
app/models/concerns/ci/processable.rb
View file @
8850da27
...
...
@@ -17,7 +17,7 @@ module Ci
end
def
when
r
aise
NotImplementedError
r
ead_attribute
(
:when
)
||
'on_success'
end
def
expanded_environment_name
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment