Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
95047f1d
Commit
95047f1d
authored
Dec 30, 2016
by
Valery Sizov
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Make diff discussion more reliable
parent
c2173a14
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
9 additions
and
3 deletions
+9
-3
app/models/merge_request.rb
app/models/merge_request.rb
+5
-3
changelogs/unreleased/fix_broken_diff_discussions.yml
changelogs/unreleased/fix_broken_diff_discussions.yml
+4
-0
No files found.
app/models/merge_request.rb
View file @
95047f1d
...
...
@@ -861,11 +861,13 @@ class MergeRequest < ActiveRecord::Base
paths:
paths
)
transaction
do
active_diff_notes
.
each
do
|
note
|
service
.
execute
(
note
)
Gitlab
::
Timeless
.
timeless
(
note
,
&
:save
)
end
end
end
def
keep_around_commit
project
.
repository
.
keep_around
(
self
.
merge_commit_sha
)
...
...
changelogs/unreleased/fix_broken_diff_discussions.yml
0 → 100644
View file @
95047f1d
---
title
:
Make MR-review-discussions more reliable
merge_request
:
author
:
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment