Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
96122034
Commit
96122034
authored
8 years ago
by
Andrei Gliga
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
more readable specs for enabled_button_based_providers and button_based_providers_enabled?
parent
81d0a4a4
No related merge requests found
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
29 additions
and
15 deletions
+29
-15
spec/helpers/auth_helper_spec.rb
spec/helpers/auth_helper_spec.rb
+29
-15
No files found.
spec/helpers/auth_helper_spec.rb
View file @
96122034
...
...
@@ -23,11 +23,14 @@ describe AuthHelper do
allow
(
helper
).
to
receive
(
:auth_providers
)
{
[
:twitter
,
:github
]
}
end
context
'all providers are enabled to sign in'
do
it
'returns all the enabled providers from settings'
do
expect
(
helper
.
enabled_button_based_providers
).
to
include
(
*
[
'twitter'
,
'github'
])
expect
(
helper
.
enabled_button_based_providers
).
to
include
(
'twitter'
,
'github'
)
end
end
it
"should not return github as provider because it's disabled from settings"
do
context
'GitHub OAuth sign in is disabled from application setting'
do
it
"doesn't return github as provider"
do
stub_application_setting
(
disabled_oauth_sign_in_sources:
[
'github'
]
)
...
...
@@ -35,12 +38,22 @@ describe AuthHelper do
expect
(
helper
.
enabled_button_based_providers
).
to
include
(
'twitter'
)
expect
(
helper
.
enabled_button_based_providers
).
to_not
include
(
'github'
)
end
end
end
it
'returns true for button_based_providers_enabled? because there providers'
do
describe
'button_based_providers_enabled?'
do
before
do
allow
(
helper
).
to
receive
(
:auth_providers
)
{
[
:twitter
,
:github
]
}
end
context
'button based providers enabled'
do
it
'returns true'
do
expect
(
helper
.
button_based_providers_enabled?
).
to
be
true
end
end
it
'returns false for button_based_providers_enabled? because there providers'
do
context
'all the button based providers are disabled via application_setting'
do
it
'returns false'
do
stub_application_setting
(
disabled_oauth_sign_in_sources:
[
'github'
,
'twitter'
]
)
...
...
@@ -48,4 +61,5 @@ describe AuthHelper do
expect
(
helper
.
button_based_providers_enabled?
).
to
be
false
end
end
end
end
This diff is collapsed.
Click to expand it.
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment