Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
b1d07760
Commit
b1d07760
authored
Mar 13, 2017
by
Phil Hughes
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fixed search specs
Clean up the events when the modal window is closed
parent
3e95bd97
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
6 additions
and
2 deletions
+6
-2
app/assets/javascripts/boards/components/modal/filters.js
app/assets/javascripts/boards/components/modal/filters.js
+2
-1
app/assets/stylesheets/pages/boards.scss
app/assets/stylesheets/pages/boards.scss
+2
-1
spec/features/boards/add_issues_modal_spec.rb
spec/features/boards/add_issues_modal_spec.rb
+2
-0
No files found.
app/assets/javascripts/boards/components/modal/filters.js
View file @
b1d07760
...
@@ -15,7 +15,8 @@ export default {
...
@@ -15,7 +15,8 @@ export default {
this
.
filteredSearch
=
new
FilteredSearchBoards
(
this
.
store
,
false
);
this
.
filteredSearch
=
new
FilteredSearchBoards
(
this
.
store
,
false
);
},
},
destroyed
()
{
beforeDestroy
()
{
this
.
filteredSearch
.
cleanup
();
FilteredSearchContainer
.
container
=
document
;
FilteredSearchContainer
.
container
=
document
;
this
.
store
.
path
=
''
;
this
.
store
.
path
=
''
;
},
},
...
...
app/assets/stylesheets/pages/boards.scss
View file @
b1d07760
...
@@ -421,7 +421,8 @@
...
@@ -421,7 +421,8 @@
display
:
flex
;
display
:
flex
;
.issues-filters
{
.issues-filters
{
width
:
100%
;
-webkit-flex
:
1
;
flex
:
1
;
}
}
}
}
...
...
spec/features/boards/add_issues_modal_spec.rb
View file @
b1d07760
...
@@ -107,6 +107,7 @@ describe 'Issue Boards add issue modal', :feature, :js do
...
@@ -107,6 +107,7 @@ describe 'Issue Boards add issue modal', :feature, :js do
it
'returns issues'
do
it
'returns issues'
do
page
.
within
(
'.add-issues-modal'
)
do
page
.
within
(
'.add-issues-modal'
)
do
find
(
'.form-control'
).
native
.
send_keys
(
issue
.
title
)
find
(
'.form-control'
).
native
.
send_keys
(
issue
.
title
)
find
(
'.form-control'
).
native
.
send_keys
(
:enter
)
expect
(
page
).
to
have_selector
(
'.card'
,
count:
1
)
expect
(
page
).
to
have_selector
(
'.card'
,
count:
1
)
end
end
...
@@ -115,6 +116,7 @@ describe 'Issue Boards add issue modal', :feature, :js do
...
@@ -115,6 +116,7 @@ describe 'Issue Boards add issue modal', :feature, :js do
it
'returns no issues'
do
it
'returns no issues'
do
page
.
within
(
'.add-issues-modal'
)
do
page
.
within
(
'.add-issues-modal'
)
do
find
(
'.form-control'
).
native
.
send_keys
(
'testing search'
)
find
(
'.form-control'
).
native
.
send_keys
(
'testing search'
)
find
(
'.form-control'
).
native
.
send_keys
(
:enter
)
expect
(
page
).
not_to
have_selector
(
'.card'
)
expect
(
page
).
not_to
have_selector
(
'.card'
)
expect
(
page
).
not_to
have_content
(
"You haven't added any issues to your project yet"
)
expect
(
page
).
not_to
have_content
(
"You haven't added any issues to your project yet"
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment