Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
bcd2135e
Commit
bcd2135e
authored
Aug 28, 2017
by
Simon Knox
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
fix transient test failures caused by wrong dropdown trigger
parent
ef8eb3f6
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
3 additions
and
3 deletions
+3
-3
spec/features/snippets/notes_on_personal_snippets_spec.rb
spec/features/snippets/notes_on_personal_snippets_spec.rb
+1
-1
spec/support/features/reportable_note_shared_examples.rb
spec/support/features/reportable_note_shared_examples.rb
+1
-1
spec/support/helpers/note_interaction_helpers.rb
spec/support/helpers/note_interaction_helpers.rb
+1
-1
No files found.
spec/features/snippets/notes_on_personal_snippets_spec.rb
View file @
bcd2135e
...
@@ -91,7 +91,7 @@ describe 'Comments on personal snippets', :js do
...
@@ -91,7 +91,7 @@ describe 'Comments on personal snippets', :js do
context
'when editing a note'
do
context
'when editing a note'
do
it
'changes the text'
do
it
'changes the text'
do
find
(
'.js-note-edit'
).
click
find
(
'.js-note-edit'
).
trigger
(
'click'
)
page
.
within
(
'.current-note-edit-form'
)
do
page
.
within
(
'.current-note-edit-form'
)
do
fill_in
'note[note]'
,
with:
'new content'
fill_in
'note[note]'
,
with:
'new content'
...
...
spec/support/features/reportable_note_shared_examples.rb
View file @
bcd2135e
...
@@ -34,7 +34,7 @@ shared_examples 'reportable note' do
...
@@ -34,7 +34,7 @@ shared_examples 'reportable note' do
end
end
def
open_dropdown
(
dropdown
)
def
open_dropdown
(
dropdown
)
dropdown
.
click
dropdown
.
find
(
'.more-actions-toggle'
).
trigger
(
'click'
)
dropdown
.
find
(
'.dropdown-menu li'
,
match: :first
)
dropdown
.
find
(
'.dropdown-menu li'
,
match: :first
)
end
end
end
end
spec/support/helpers/note_interaction_helpers.rb
View file @
bcd2135e
...
@@ -2,7 +2,7 @@ module NoteInteractionHelpers
...
@@ -2,7 +2,7 @@ module NoteInteractionHelpers
def
open_more_actions_dropdown
(
note
)
def
open_more_actions_dropdown
(
note
)
note_element
=
find
(
"#note_
#{
note
.
id
}
"
)
note_element
=
find
(
"#note_
#{
note
.
id
}
"
)
note_element
.
find
(
'.more-actions
'
).
click
note_element
.
find
(
'.more-actions
-toggle'
).
trigger
(
'click'
)
note_element
.
find
(
'.more-actions .dropdown-menu li'
,
match: :first
)
note_element
.
find
(
'.more-actions .dropdown-menu li'
,
match: :first
)
end
end
end
end
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment