Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
c009e23a
Commit
c009e23a
authored
Apr 30, 2019
by
Sean McGivern
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Give reviewer roulette its own header in the docs
parent
d232137a
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
20 additions
and
5 deletions
+20
-5
doc/development/code_review.md
doc/development/code_review.md
+20
-5
No files found.
doc/development/code_review.md
View file @
c009e23a
...
@@ -23,11 +23,6 @@ one of the [Merge request coaches][team].
...
@@ -23,11 +23,6 @@ one of the [Merge request coaches][team].
If you need assistance with security scans or comments, feel free to include the
If you need assistance with security scans or comments, feel free to include the
Security Team (
`@gitlab-com/gl-security`
) in the review.
Security Team (
`@gitlab-com/gl-security`
) in the review.
The
`danger-review`
CI job will randomly pick a reviewer and a maintainer for
each area of the codebase that your merge request seems to touch. It only makes
recommendations - feel free to override it if you think someone else is a better
fit!
Depending on the areas your merge request touches, it must be
**approved**
by one
Depending on the areas your merge request touches, it must be
**approved**
by one
or more
[
maintainers
](
https://about.gitlab.com/handbook/engineering/workflow/code-review/#maintainer
)
:
or more
[
maintainers
](
https://about.gitlab.com/handbook/engineering/workflow/code-review/#maintainer
)
:
...
@@ -37,6 +32,26 @@ widget. Reviewers can add their approval by [approving additionally](https://doc
...
@@ -37,6 +32,26 @@ widget. Reviewers can add their approval by [approving additionally](https://doc
Getting your merge request
**merged**
also requires a maintainer. If it requires
Getting your merge request
**merged**
also requires a maintainer. If it requires
more than one approval, the last maintainer to review and approve it will also merge it.
more than one approval, the last maintainer to review and approve it will also merge it.
### Reviewer roulette
The
`danger-review`
CI job will randomly pick a reviewer and a maintainer for
each area of the codebase that your merge request seems to touch. It only makes
recommendations - feel free to override it if you think someone else is a better
fit!
It picks reviewers and maintainers from the list at the
[
engineering projects
](
https://about.gitlab.com/handbook/engineering/projects/
)
page, with these behaviours:
1.
It will not pick people whose
[
GitLab status
](
../user/profile/#current-status
)
contains the string 'OOO'.
2.
[
Trainee maintainers
](
https://about.gitlab.com/handbook/engineering/workflow/code-review/#trainee-maintainer
)
are three times as likely to be picked as other reviewers.
3.
It always picks the same reviewers and maintainers for the same
branch name (unless their OOO status changes, as in point 1). It
removes leading
`ce-`
and
`ee-`
, and trailing
`-ce`
and
`-ee`
, so
that it can be stable for backport branches.
### Approval guidelines
### Approval guidelines
As described in the section on the responsibility of the maintainer below, you
As described in the section on the responsibility of the maintainer below, you
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment