Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
c739b8e0
Commit
c739b8e0
authored
Nov 12, 2018
by
Kamil Trzciński
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Just fix (hack) specs
parent
bb8d0e7c
Changes
4
Show whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
9 additions
and
9 deletions
+9
-9
spec/models/ci/build_spec.rb
spec/models/ci/build_spec.rb
+1
-1
spec/models/environment_status_spec.rb
spec/models/environment_status_spec.rb
+1
-1
spec/services/update_deployment_service_spec.rb
spec/services/update_deployment_service_spec.rb
+6
-6
spec/support/helpers/cycle_analytics_helpers.rb
spec/support/helpers/cycle_analytics_helpers.rb
+1
-1
No files found.
spec/models/ci/build_spec.rb
View file @
c739b8e0
...
...
@@ -800,7 +800,7 @@ describe Ci::Build do
end
describe
'state transition as a deployable'
do
let!
(
:build
)
{
create
(
:ci_build
,
:start_review_app
)
}
let!
(
:build
)
{
create
(
:ci_build
,
:start_review_app
)
.
reload
}
let
(
:deployment
)
{
build
.
deployment
}
let
(
:environment
)
{
deployment
.
environment
}
...
...
spec/models/environment_status_spec.rb
View file @
c739b8e0
...
...
@@ -94,7 +94,7 @@ describe EnvironmentStatus do
describe
'.build_environments_status'
do
subject
{
described_class
.
send
(
:build_environments_status
,
merge_request
,
user
,
sha
)
}
let!
(
:build
)
{
create
(
:ci_build
,
:deploy_to_production
,
pipeline:
pipeline
)
}
let!
(
:build
)
{
create
(
:ci_build
,
:deploy_to_production
,
pipeline:
pipeline
)
.
reload
}
let
(
:environment
)
{
build
.
deployment
.
environment
}
let
(
:user
)
{
project
.
owner
}
...
...
spec/services/update_deployment_service_spec.rb
View file @
c739b8e0
...
...
@@ -10,7 +10,7 @@ describe UpdateDeploymentService do
tag:
false
,
environment:
'production'
,
options:
{
environment:
options
},
project:
project
)
project:
project
)
.
reload
end
let
(
:project
)
{
create
(
:project
,
:repository
)
}
...
...
@@ -99,7 +99,7 @@ describe UpdateDeploymentService do
ref:
'master'
,
environment:
'production'
,
project:
project
,
options:
{
environment:
{
name:
'production'
,
url:
'http://review/$CI_COMMIT_REF_NAME'
}
})
options:
{
environment:
{
name:
'production'
,
url:
'http://review/$CI_COMMIT_REF_NAME'
}
})
.
reload
end
it
{
is_expected
.
to
eq
(
'http://review/master'
)
}
...
...
@@ -111,7 +111,7 @@ describe UpdateDeploymentService do
ref:
'master'
,
environment:
'prod-slug'
,
project:
project
,
options:
{
environment:
{
name:
'prod-slug'
,
url:
'http://review/$CI_ENVIRONMENT_SLUG'
}
})
options:
{
environment:
{
name:
'prod-slug'
,
url:
'http://review/$CI_ENVIRONMENT_SLUG'
}
})
.
reload
end
it
{
is_expected
.
to
eq
(
'http://review/prod-slug'
)
}
...
...
@@ -123,14 +123,14 @@ describe UpdateDeploymentService do
yaml_variables:
[{
key: :APP_HOST
,
value:
'host'
}],
environment:
'production'
,
project:
project
,
options:
{
environment:
{
name:
'production'
,
url:
'http://review/$APP_HOST'
}
})
options:
{
environment:
{
name:
'production'
,
url:
'http://review/$APP_HOST'
}
})
.
reload
end
it
{
is_expected
.
to
eq
(
'http://review/host'
)
}
end
context
'when yaml environment does not have url'
do
let
(
:job
)
{
create
(
:ci_build
,
environment:
'staging'
,
project:
project
)
}
let
(
:job
)
{
create
(
:ci_build
,
environment:
'staging'
,
project:
project
)
.
reload
}
it
'returns the external_url from persisted environment'
do
is_expected
.
to
be_nil
...
...
@@ -160,7 +160,7 @@ describe UpdateDeploymentService do
tag:
false
,
environment:
'staging'
,
options:
{
environment:
{
name:
'staging'
}
},
project:
project
)
project:
project
)
.
reload
end
it
"doesn't set the time if the deploy's environment is not 'production'"
do
...
...
spec/support/helpers/cycle_analytics_helpers.rb
View file @
c739b8e0
...
...
@@ -115,7 +115,7 @@ module CycleAnalyticsHelpers
name:
'dummy'
,
stage:
'dummy'
,
pipeline:
dummy_pipeline
(
project
),
protected:
false
)
protected:
false
)
.
reload
end
def
mock_gitaly_multi_action_dates
(
repository
,
commit_time
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment