Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
de7901ff
Commit
de7901ff
authored
Dec 11, 2017
by
Grzegorz Bizon
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix minor Rubocop offenses in QA browser runtime
parent
b80dc884
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
4 additions
and
2 deletions
+4
-2
qa/qa/page/base.rb
qa/qa/page/base.rb
+3
-1
qa/qa/runtime/browser.rb
qa/qa/runtime/browser.rb
+1
-1
No files found.
qa/qa/page/base.rb
View file @
de7901ff
...
@@ -13,8 +13,10 @@ module QA
...
@@ -13,8 +13,10 @@ module QA
def
wait
(
css
=
'.application'
,
time:
60
)
def
wait
(
css
=
'.application'
,
time:
60
)
Time
.
now
.
tap
do
|
start
|
Time
.
now
.
tap
do
|
start
|
while
Time
.
now
-
start
<
time
while
Time
.
now
-
start
<
time
break
if
page
.
has_css?
(
css
,
wait:
5
)
puts
"Waiting for `
#{
css
}
on `
#{
current_url
}
`"
puts
"Waiting for `
#{
css
}
on `
#{
current_url
}
`"
break
if
page
.
has_css?
(
css
,
wait:
5
)
refresh
refresh
end
end
end
end
...
...
qa/qa/runtime/browser.rb
View file @
de7901ff
...
@@ -79,7 +79,7 @@ module QA
...
@@ -79,7 +79,7 @@ module QA
def
perform
(
&
block
)
def
perform
(
&
block
)
visit
(
@address
)
visit
(
@address
)
block
.
call
if
block_given?
yield
if
block_given?
rescue
rescue
raise
if
block
.
nil?
raise
if
block
.
nil?
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment